[HOLD for payment 2024-02-20] [$500] Android - Receipt - App crashes when downloading EReceipt from Expensify Card transaction

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.24-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Log in to account with Expensify Card transaction (tester@applausecard.expensifail.com
Go to workspace chat with the transaction (https://staging.new.expensify.com/r/4612388815642526
Navigate to transaction details page.
Tap on the e-receipt > 3-dot menu > Download.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6338794_1704974766409.Screen_Recording_20240111_113849_One_UI_Home.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c571000bd51ff4ec
Upwork Job ID: 1745431775064920064
Last Price Increase: 2024-02-01
Automatic offers:

fedirjh | Reviewer | 28142516
mkhutornyi | Contributor | 28142517

Job added to Upwork: https://www.upwork.com/jobs/~01c571000bd51ff4ec

@sophiepintoraetz

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@fedirjh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

Proposal

Please re-state the problem that we are trying to solve in this issue

App crashes when downloading EReceipt from Expensify Card transaction.

Instructions to reproduce issue on local development

This will add an EReceipt Card locally in Onyx.

Create a manual request.
Within MoneyRequestPreview.js console log props.transaction.
Tap on created request and extract transactionID from logs.
Within MoneyRequestPreview.js under the first console log add the following console log replacing transactionID with the one extracted from the logs:

Details

    console.log(Onyx.merge("transactions_transactionID", { // <- make sure to change transactionID
        cardID: 1,
        merchant: 'Google', // Random merchant
        mccGroup: 'Android', // Random group
        hasEReceipt: true,
    }));

Now when re-visiting the created manual request this will have an EReceipt Card attached

Note: keep the step 4 console log within the code because if removed the EReceipt won't persist due to transaction re-fetching when navigating.

What is the root cause of that problem?

The crash happens because the source url we're trying to download has the following form: eReceipt/3792612540331572334 because it's an EReceipt component created by us within the app and doesn't have a HTTP/HTTPS url source, therefore the download errors with: Can only download HTTP/HTTPS URIs which crashes the app.

What changes do you think we should make in order to solve the problem?

Using a package we already use called react-native-view-shot we can pass down a ref to the EReceipt component and capture it as an image which we can then save to the device camera roll upon downloading.

Pseudo code:

within AttachmentModal.js create new ref called eReceiptViewRef
pass down ref to AttachmentView then once more to EReceipt's the wrapping View
back in AttachmentModal.js above the downloadAttachment function define isEReceipt constant like so:
!_.isEmpty(props.transaction) && TransactionUtils.hasEReceipt(props.transaction)
inside the downloadAttachment function after if (isAuthTokenRequired) add if (isEReceipt)
within the isEReceipt if we use react-native-view-shot's captureRef function to capture the EReceipt, save it to the camera roll then display an alert that notices the user that the attachment was saved to camera roll

What alternative solutions did you explore? (Optional)

As per #34348 (comment), as an alternative to fixing this issue we should hide the download button for EReceipt attachments by adding an additional check in the line:

App/src/components/AttachmentModal.js

Line 420 in 045a0d0

if (!isOffline) {

for when the attachment is an eReceipt in order to hide the download button on all platforms since:

the download feature for EReceipt was not implemented yet in ND.

We can check for eReceipt like so:

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Line 49 in 0ead105

const isEReceipt = transaction && TransactionUtils.hasEReceipt(transaction);

Videos

iOS: Native

Screen.Recording.2024-01-13.at.03.39.14.mov

Android: Native

Screen.Recording.2024-01-13.at.02.56.48.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-16.at.18.39.55.mov

MacOS: Desktop

Screen.Recording.2024-01-16.at.18.46.12.mov

@fedirjh

With @fedirjh to review the proposal

Reviewing label has been removed, please complete the "BugZero Checklist".

@fedirjh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

disable downloading EReceipt #36030

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment automatic offer (Reviewer)
@mkhutornyi requires payment automatic offer (Contributor)

@fedirjh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@fedirjh

Hey @fedirjh please complete the checklist above. Thanks!

@fedirjh

Payment summary:

@fedirjh automatic offer (Reviewer) $500
@mkhutornyi automatic offer (Contributor) $500

@fedirjh

The payments were processed in Upwork. Waiting for @fedirjh to complete the BZ list.

BugZero Checklist:

Link to the PR: Remove receipt from carousel #31467
Link to comment: Remove receipt from carousel #31467 (comment)
Link to discussion: N/A Nothing to add to the checklist.
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

1. Log in to account with Expensify Card transaction : tester@applausecard.expensifail.com
2. Go to workspace chat with the transaction https://staging.new.expensify.com/r/4612388815642526
3. Navigate to transaction details page.
4. Open receipt preview
5. Verify that download icon doesn't show. If three dots menu exists, verify that it doesn't contain download icon option.

Do we agree 👍 or 👎

Regression test:

https://github.com/Expensify/Expensify/issues/371827

All set.

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-20] [$500] Android - Receipt - App crashes when downloading EReceipt from Expensify Card transaction #34348

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue

Instructions to reproduce issue on local development

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Videos

45 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-02-20] [$500] Android - Receipt - App crashes when downloading EReceipt from Expensify Card transaction #34348

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 11, 2024

melvin-bot commented on Jan 11, 2024

melvin-bot commented on Jan 11, 2024

ikevin127 commented on Jan 13, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue

Instructions to reproduce issue on local development

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Videos

sophiepintoraetz commented on Jan 14, 2024

45 remaining items

melvin-bot commented on Feb 13, 2024

melvin-bot commented on Feb 13, 2024

melvin-bot commented on Feb 13, 2024

isabelastisser commented on Feb 21, 2024

isabelastisser commented on Feb 21, 2024

isabelastisser commented on Feb 21, 2024

fedirjh commented on Feb 21, 2024

BugZero Checklist:

isabelastisser commented on Feb 22, 2024

isabelastisser commented on Feb 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions