You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-26] App crashes clicking on the hyperlinked room #34378
changed the title [-]App crashes clicking on the hyperlinked room[/-][+][HOLD for payment 2024-02-26] App crashes clicking on the hyperlinked room[/+]on Feb 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jan 11, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.AndrewGable commentedon Jan 11, 2024
I assume this will be fixed by just updating the NewDot version, so this should fix it: #33915
melvin-bot commentedon Jan 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~017f1a4fd680a21e07
melvin-bot commentedon Jan 12, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (
Internal)sakluger commentedon Jan 12, 2024
Oh, I just added the internal label but then noticed @AndrewGable's comment that this should be fixed by #33915. Putting on hold for that issue.
[-]App crashes clicking on the hyperlinked room[/-][+][HOLD 33915] App crashes clicking on the hyperlinked room[/+]21 remaining items
allroundexperts commentedon Feb 14, 2024
Can someone please assign me this issue since I reviewed the PR and the payment is pending here?
[-]App crashes clicking on the hyperlinked room[/-][+][HOLD for payment 2024-02-26] App crashes clicking on the hyperlinked room[/+]melvin-bot commentedon Feb 19, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 19, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: