Skip to content

[HOLD for payment 2024-02-26] App crashes clicking on the hyperlinked room #34378

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dylanexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704974903216559

Action Performed:

  1. Head to Expensify App (oldApp)
  2. Click Hamburger menu
  3. Click Settings
  4. Click Try New Expensify
  5. Go to
  6. private channel
  7. room
  8. Click on a hyperlinked room (e.g.
  9. private channel)

Expected Result:

You are taken to the room

Actual Result:

App crashes

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1704974753.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017f1a4fd680a21e07
  • Upwork Job ID: 1745604087503478784
  • Last Price Increase: 2024-01-12

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 11, 2024
  2. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. AndrewGable commented on Jan 11, 2024

    @AndrewGable
    Contributor

    I assume this will be fixed by just updating the NewDot version, so this should fix it: #33915

  4. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 12, 2024
  5. melvin-bot commented on Jan 12, 2024

    @melvin-bot
  6. melvin-bot commented on Jan 12, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

  7. sakluger commented on Jan 12, 2024

    @sakluger
    Contributor

    Oh, I just added the internal label but then noticed @AndrewGable's comment that this should be fixed by #33915. Putting on hold for that issue.

  8. changed the title [-]App crashes clicking on the hyperlinked room[/-] [+][HOLD 33915] App crashes clicking on the hyperlinked room[/+] on Jan 12, 2024
  9. 21 remaining items

  10. moved this from Release 1: Hybrid App V1 to Done in [#whatsnext] Wave 05 - Deprecate Freeon Feb 13, 2024
  11. allroundexperts commented on Feb 14, 2024

    @allroundexperts
    Contributor

    Can someone please assign me this issue since I reviewed the PR and the payment is pending here?

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 19, 2024
  13. changed the title [-]App crashes clicking on the hyperlinked room[/-] [+][HOLD for payment 2024-02-26] App crashes clicking on the hyperlinked room[/+] on Feb 19, 2024
  14. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-26. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions