Repository navigation
[$500] Request money - Deleted request shows empty details when the details page has messages #34425
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.24-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Go to workspace chat.
- Create any request.
- Go to the details page and send a message.
- Click 3-dot menu > Delete request.
- Delete the request.
Expected Result:
The request details page will be blank except the bottom part where it shows messages (previous behavior).
Actual Result:
The request details page shows empty details (Amount, date, description etc).
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6339833_1705045583836.20240111_215828.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d86a2dfc9f2be794
- Upwork Job ID: 1745748245116649472
- Last Price Increase: 2024-02-02
- Automatic offers:
- dukenv0307 | Contributor | 28142050
Activity
[-]Request money - Deleted request shows empty details when the details page has messages[/-][+][$500] Request money - Deleted request shows empty details when the details page has messages[/+]melvin-bot commentedon Jan 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d86a2dfc9f2be794
melvin-bot commentedon Jan 12, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 12, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)dukenv0307 commentedon Jan 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The request details page shows empty details (Amount, date, description etc).
What is the root cause of that problem?
We always display
MoneyRequestViewin transaction thread reportApp/src/pages/home/report/ReportActionItem.js
Line 579 in b6a18b1
What changes do you think we should make in order to solve the problem?
We can display
[Deleted Request]message if the transaction is deleted the same way as we do for the canceled task.We can do that by checking
ReportActionsUtils.isDeletedParentAction(parentReportAction)App/src/pages/home/report/ReportActionItem.js
Line 579 in b6a18b1
App/src/pages/home/report/ReportActionItem.js
Line 587 in b6a18b1
What alternative solutions did you explore? (Optional)
In
MoneyRequestView, we can return null or return[Deleted Request]if the transaction is deleted (isundefined) or checkReportActionsUtils.isDeletedParentAction(parentReportAction)as we do inMoneyRequestActionbernhardoj commentedon Jan 12, 2024
The temporary code to hide the money request view was cleaned up in #33633
cc: @youssef-lr
dukenv0307 commentedon Jan 12, 2024
Actually, we are using
transactionas props inMoneyRequestView, so we can do it as a new issue to fix this case.melvin-bot commentedon Jan 15, 2024
@sobitneupane, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!
47 remaining items
dukenv0307 commentedon Feb 15, 2024
@allroundexperts The PR is ready for review.
melvin-bot commentedon Mar 11, 2024
This issue has not been updated in over 15 days. @MariaHCD, @allroundexperts, @muttmuure, @dukenv0307 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
allroundexperts commentedon Mar 11, 2024
This was deployed to production 2 weeks ago. I think we're just pending the payment here. cc @muttmuure
muttmuure commentedon Mar 20, 2024
$500 - @allroundexperts for C+
$500 - @dukenv0307 paid on Upwork
JmillsExpensify commentedon Apr 1, 2024
$500 approved for @allroundexperts
melvin-bot commentedon Apr 9, 2024
This issue has not been updated in over 14 days. @MariaHCD, @allroundexperts, @muttmuure, @dukenv0307 eroding to Weekly issue.