Repository navigation
[HOLD #37281][$1000] Onyx data does not get removed cleanly on sign out #34473
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: needs reproduction ( Don't have account with several hundreds of chats)
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705012041676559
Action Performed:
- Signed into an account with many many chats
- Signed out
- Signed in with a brand new account (which should have only the Concierge chat)
Expected Result:
Nothing from the account that I signed out from should be persisted in the client data whatsoever.
Actual Result:
Tons of chats from the first account show up in the second account. A ton of Onyx keys still have values of {hasDraft: false} and there are also straight up reports that shouldn't be there at all. These also show up in the LHN.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01211aa8ecc46d7a5e
- Upwork Job ID: 1759703332875366400
- Last Price Increase: 2024-03-24
Activity
melvin-bot commentedon Jan 13, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 16, 2024
@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!
anmurali commentedon Jan 16, 2024
I cannot reproduce
The two reports I see are Concierge DM and domain room, and the new account has both.
@marcaaron can you test this again and reopen if you still run into it?
marcaaron commentedon Jan 17, 2024
It seems dependent on how much data you have in the first account when signing out. If you have a lot - not all of it gets cleared.
We can close it - but feels like there is some obvious reason why this is happening and it should be patched at some point. Switching from one account to another is not such a common thing though so we can deprioritize it for now (but it is still happening for me).
melvin-bot commentedon Feb 19, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01211aa8ecc46d7a5e
melvin-bot commentedon Feb 19, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (
Internal)87 remaining items
mallenexpensify commentedon Mar 26, 2024
Put on hold, removed
ExternalandHelp Wanted, bumped toWeeklyThanks @shubham1206agra for the tip!
s77rt commentedon Apr 5, 2024
#37281 is merged. Issue not longer reproducible. Let's close this
mallenexpensify commentedon Apr 7, 2024
Throwing
retest-weeklyon this to confirm, then we can close. thx!anmurali commentedon Apr 17, 2024
@mallenexpensify any updates?
mallenexpensify commentedon Apr 18, 2024
Closing, just tried to repro with no luck
