Skip to content

[HOLD for payment 2024-02-07] [$500] Magic code - An additional page appears when navigate from Abracadabra page #34567

New issue
New issue
Closed
Closed
[HOLD for payment 2024-02-07] [$500] Magic code - An additional page appears when navigate from Abracadabra page#34567
Assignees
mallenexpensifyjjcoffeemountinydummy-1111
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Jan 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.25-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Create new account
  2. Copy the Magic link and change it to staging
  3. Open a new tab and navigate to the staging magic link> change the last numbers
  4. Verify the a Magic code expired page is displayed
  5. Navigate to the original tab

Expected Result:

Original tab( magic code page) should be open

Actual Result:

An additional page appears (Magic code page flickers) when navigate from Abracadabra page to original tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343716_1705361816806.Recording__1817.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0139aec2eed464b4a1
  • Upwork Job ID: 1747260699342594048
  • Last Price Increase: 2024-01-16
  • Automatic offers:
    • jjcoffee | Reviewer | 28108571
    • s-alves10 | Contributor | 28108572
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 16, 2024
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Jan 16, 2024

  3. github-actions commented on Jan 16, 2024

    @github-actions
    github-actionsBot
    on Jan 16, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot
    assigned
    mountiny
    on Jan 16, 2024

  5. melvin-bot commented on Jan 16, 2024

    @melvin-bot
    melvin-botBot
    on Jan 16, 2024 – with Melvin Bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. situchan commented on Jan 16, 2024

    @situchan
    situchan
    on Jan 16, 2024
    Contributor

    This looks similar to #34532. Can we ask QA team to retest on v1.4.25-6?

  7. mountiny commented on Jan 16, 2024

    @mountiny
    mountiny
    on Jan 16, 2024
    Contributor

    yep already did, had the same idea

  8. isagoico commented on Jan 16, 2024

    @isagoico
    isagoico
    on Jan 16, 2024

    This issue is still reproducible in 25-6. Also noticed that after going back to the login tab:

    • The go back button is unresponsive
    • The request link timer resets back to 30 seconds every time the user navigates away and back
    magic.link.mp4
  9. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 16, 2024

  10. melvin-bot commented on Jan 16, 2024

    @melvin-bot
    melvin-botBot
    on Jan 16, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~0139aec2eed464b4a1

  11. melvin-bot
    changed the title [-]Magic code - An additional page appears when navigate from Abracadabra page[/-] [+][$500] Magic code - An additional page appears when navigate from Abracadabra page[/+] on Jan 16, 2024
  12. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 16, 2024
  13. melvin-bot
    assigned
    jjcoffee
    on Jan 16, 2024

  14. melvin-bot commented on Jan 16, 2024

    @melvin-bot
    melvin-botBot
    on Jan 16, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  15. 37 remaining items

  16. melvin-bot commented on Jan 31, 2024

    @melvin-bot
    melvin-botBot
    on Jan 31, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Jan 31, 2024

    @melvin-bot
    melvin-botBot
    on Jan 31, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-07. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Jan 31, 2024

    @melvin-bot
    melvin-botBot
    on Jan 31, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
    • [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jjcoffee] Determine if we should create a regression test for this bug.
    • [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  19. mountiny commented on Jan 31, 2024

    @mountiny
    mountiny
    on Jan 31, 2024
    Contributor

    Yeah I agree this is minor

  20. jjcoffee commented on Feb 5, 2024

    @jjcoffee
    jjcoffee
    on Feb 5, 2024
    Contributor

    Regression Test Proposal

    Web only:

    1. Log out if logged in
    2. Enter email or phone number and tap Continue to go to the magic code page
    3. Open a new tab and navigate to the magic link (edit the magic code in the link to make the code invalid, e.g. change the last number)
    4. Verify that the magic code expired page is displayed
    5. Navigate to the original tab and switch back and forth between the tabs
    6. Verify that the magic code page is opened without any flickering of the "Another login page is open" text

    Do we agree 👍 or 👎

  21. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Feb 6, 2024

  22. melvin-bot commented on Feb 9, 2024

    @melvin-bot
    melvin-botBot
    on Feb 9, 2024 – with Melvin Bot

    @mallenexpensify, @jjcoffee, @mountiny, @s-alves10 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  23. mallenexpensify commented on Feb 9, 2024

    @mallenexpensify
    mallenexpensify
    on Feb 9, 2024
    Contributor

    Contributor: @s-alves10 paid $500 via Upwork
    Contributor+: @jjcoffee paid $500 via Upwork.

    Testrail GH https://github.com/Expensify/Expensify/issues/368509

    Thanks!

  24. mallenexpensify
    closed this as completedon Feb 9, 2024
  25. melvin-bot
    removed
    Overdue
    on Feb 9, 2024

  26. greg-schroeder commented on Feb 16, 2024

    @greg-schroeder
    greg-schroeder
    on Feb 16, 2024
    Contributor

    Hey all - can anyone confirm if this issue might be related to what was implemented here?

    #36651

  27. dummy-1111 commented on Feb 16, 2024

    @dummy-1111
    dummy-1111
    on Feb 16, 2024
    Contributor

    @greg-schroeder

    Yes, I think so. I show the Another Login Page is Open view only when both tabs or windows are visible intentionally. Isn't this enough?

  28. greg-schroeder commented on Feb 16, 2024

    @greg-schroeder
    greg-schroeder
    on Feb 16, 2024
    Contributor

    Thanks @s-alves10! I'll close that other one as expected behavior then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions