[HOLD for payment 2024-01-30] [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-24] [$500] Android - App crashes when downloading attachments

@kadiealexander

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.25-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: user has a device running Android 14

Open the app and log in
Navigate to a chat with some attachments
Open any attachment
Tap the download icon

Expected Result:

The attachment has been successfully downloaded, the pop-up is displayed

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6343839_1705372708927.video_2024-01-15_21-37-31.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d74c3eb5115eee4f
Upwork Job ID: 1747295636132077568
Last Price Increase: 2024-01-16

Issue Owner

Current Issue Owner: @kadiealexander

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Gonals

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv

@kbecciv, I can't seem to reproduce this on Staging (Android).

@situchan

@situchan could repro on android 14 and not in android 11

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when download attachment on android 14

What is the root cause of that problem?

App/android/build.gradle

Lines 7 to 8 in 5b03db9

    
           compileSdkVersion = 34 
        
           targetSdkVersion = 34

Our app's targetSdkVersion = 34
So it's known upstream issue - RonRadtke/react-native-blob-util#303
Fixed in RonRadtke/react-native-blob-util#306

What changes do you think we should make in order to solve the problem?

Solution 1: bump react-native-blob-util to latest version
Solution 2: apply local patch for the fix in RonRadtke/react-native-blob-util#306
Solution 3: lower targetSdkVersion to 33 (RonRadtke/react-native-blob-util#303 (comment))

Discussed in slack, lets do the patch for now and then test updating to latest

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mkhutornyi

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.29-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

bump react-native-blob-util version for RN 0.73, android 14 support #34633

If no regressions arise, payment will be issued on 2024-01-30. 🎊

For reference, here are some details about the assignees on this issue:

@mkhutornyi requires payment (Needs manual offer from BZ)
@situchan requires payment (Needs manual offer from BZ)

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mkhutornyi

Payment Summary

Upwork Job

ROLE: @mkhutornyi paid $500 via Upwork (LINK)
ROLE: @situchan doesn't need payment

BugZero Checklist (@kadiealexander)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1747295636132077568/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@situchan

@situchan don't forget about the checklist!

The PR that introduced the bug has been identified. Link to the PR: chore: Update React Native to 0.73.2 #31558
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/31558/files#r1472293552
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. No need as this was caught during staging regression testing.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

FYI: I don't need payment here

@situchan

Thanks @situchan

@mkhutornyi

@mkhutornyi please accept the Upwork contract!

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-30] [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-24] [$500] Android - App crashes when downloading attachments #34569

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

35 remaining items

Payment Summary

BugZero Checklist (@kadiealexander)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-01-30] [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-24] [$500] Android - App crashes when downloading attachments #34569

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jan 16, 2024

melvin-bot commented on Jan 16, 2024

Gonals commented on Jan 16, 2024

mountiny commented on Jan 16, 2024

mkhutornyi commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

mountiny commented on Jan 16, 2024

35 remaining items

melvin-bot commented on Jan 18, 2024

melvin-bot commented on Jan 23, 2024

melvin-bot commented on Jan 23, 2024

melvin-bot commented on Jan 30, 2024

Payment Summary

BugZero Checklist (@kadiealexander)

kadiealexander commented on Jan 31, 2024

situchan commented on Jan 31, 2024

situchan commented on Jan 31, 2024

kadiealexander commented on Jan 31, 2024

kadiealexander commented on Jan 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions