[HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestConfirmPage
New Component IOURequestStepConfirmation

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d384157eb0d34e8a
Upwork Job ID: 1747632941224689664
Last Price Increase: 2024-01-17
Automatic offers:

DylanDylann | Contributor | 28109099

@adelekennedy

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js

What is the root cause of that problem?

Cleaning of MoneyRequestConfirmPage

What changes do you think we should make in order

The component here will be deleted.  

Remove this line from ModalStackNavigation.js:  

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 96 in a7a3e7f

    
           [SCREENS.MONEY_REQUEST.CONFIRMATION]: () => require('../../../pages/iou/steps/MoneyRequestConfirmPage').default as React.ComponentType,

  History page here has a few changes. Most of these are with the violations feature. We will take a look at the specific logic changes and add the changes to IOURequestStepConfirmation

I would love to take this!

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js

What is the root cause of that problem?

Remove deprecated component

What changes do you think we should make in order to solve the problem?

Remove MoneyRequestConfirmPage component and all traces like

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 96 in 278d04e

    
           [SCREENS.MONEY_REQUEST.CONFIRMATION]: () => require('../../../pages/iou/steps/MoneyRequestConfirmPage').default as React.ComponentType,

App/src/libs/Navigation/linkingConfig.ts

Line 429 in 278d04e

[SCREENS.MONEY_REQUEST.CONFIRMATION]: ROUTES.MONEY_REQUEST_CONFIRMATION.route,

App/src/ROUTES.ts

Lines 261 to 264 in a2f5bd5

    
           MONEY_REQUEST_CONFIRMATION: { 
        
               route: ':iouType/new/confirmation/:reportID?', 
        
               getRoute: (iouType: string, reportID = '') => `${iouType}/new/confirmation/${reportID}` as const, 
        
           },

App/src/SCREENS.ts

Line 141 in a2f5bd5

CONFIRMATION: 'Money_Request_Confirmation',

App/src/libs/Navigation/types.ts

Lines 188 to 191 in a2f5bd5

    
           [SCREENS.MONEY_REQUEST.CONFIRMATION]: { 
        
               iouType: string; 
        
               reportID: string; 
        
           };

For new component IOURequestStepConfirmation

In here

App/src/ROUTES.ts

Lines 308 to 311 in a2f5bd5

    
           MONEY_REQUEST_STEP_CONFIRMATION: { 
        
               route: 'create/:iouType/confirmation/:transactionID/:reportID', 
        
               getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string) => `create/${iouType}/confirmation/${transactionID}/${reportID}` as const, 
        
           },

We need to use the new :action param (instead of being hard-coded with "create") like we did here

App/src/ROUTES.ts

Lines 362 to 366 in a2f5bd5

    
           MONEY_REQUEST_STEP_SCAN: { 
        
               route: ':action/:iouType/scan/:transactionID/:reportID', 
        
               getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') => 
        
                   getUrlWithBackToParam(`${action}/${iouType}/scan/${transactionID}/${reportID}`, backTo), 
        
           },

Copy changes since 27 Nov to new components based on list commit here: https://github.com/Expensify/App/commits/main/src/pages/iou/IOURequestStepConfirmation.js

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~01d384157eb0d34e8a

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

remove MoneyRequestConfirmPage #35461

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests
@DylanDylann requires payment automatic offer (Contributor)

@adelekennedy

This is not a bug but a code refactor. Bug-zero checklist does not apply. cc: @adelekennedy

No checklist - payment is due on 4/15

@DylanDylann

Payouts due:

Contributor: $250 @DylanDylann (Upwork)
Contributor+: $250 @parasharrajat (NewDot)

Payment requested as per #34615 (comment)

@parasharrajat

$250 approved for @parasharrajat

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js #34615

Problem

Solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

63 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	MONEY_REQUEST_CONFIRMATION: {
	route: ':iouType/new/confirmation/:reportID?',
	getRoute: (iouType: string, reportID = '') => `${iouType}/new/confirmation/${reportID}` as const,
	},

	[SCREENS.MONEY_REQUEST.CONFIRMATION]: {
	iouType: string;
	reportID: string;
	};

	MONEY_REQUEST_STEP_CONFIRMATION: {
	route: 'create/:iouType/confirmation/:transactionID/:reportID',
	getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string) => `create/${iouType}/confirmation/${transactionID}/${reportID}` as const,
	},

	MONEY_REQUEST_STEP_SCAN: {
	route: ':action/:iouType/scan/:transactionID/:reportID',
	getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`${action}/${iouType}/scan/${transactionID}/${reportID}`, backTo),
	},

[HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js #34615

Description

Problem

Solution

Activity

melvin-bot commented on Jan 16, 2024

lancer-spaid commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

njmulsqb commented on Jan 17, 2024

DylanDylann commented on Jan 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

63 remaining items

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

parasharrajat commented on Apr 9, 2024

adelekennedy commented on Apr 9, 2024

adelekennedy commented on Apr 15, 2024

parasharrajat commented on May 20, 2024

JmillsExpensify commented on May 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions