[HOLD for payment 2024-02-20] [$250] Address – Incorrect error message appear when enter Cyrillic letters into Zip field

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Login to New dot
Navigate to Settings -> Profile -> Personal details
Navigate to Home address page
Add Cyrillic letters or symbols into Zip/Postcode field

Expected Result:

"Incorrect zip code format" message should appear

Actual Result:

Incorrect error message ( privatePersonalDetails.error.incorrectZipFormat ) appear when enter Cyrillic letters into Zip/Postcode field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ae2a56928644ce4f
Upwork Job ID: 1747794052740149248
Last Price Increase: 2024-01-18
Automatic offers:

s77rt | Reviewer | 28118027
dukenv0307 | Contributor | 28118028

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@jasperhuangg

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Address - Incorrect error message appear when enter Cyrillic letters into Zip field

What is the root cause of that problem?

the zip code input is inside an input wrapper where the inputcomponent prop is TextInput
inside the input wapper we call registerInput which is provided by the FormProvider context here
the registerInput function sets the errorText ---> errorText: errors[inputID] || fieldErrorMessage,
now the object returned from the registerInput is passed to the TextInput as props
the BaseTextInput component uses FormHelpMessage to display the error where the input is the errorText provided in the props
the FormHelpMessage component calls Localize.translateIfPhraseKey to translate the error message
the translateIfPhraseKey function parses the input value to fetch the passed variables to the translate function
in the case of the zipcode we don't provide a second argument to the translation making the variables object assigned to undefined which make the translate function unable to resolve the translation.

What changes do you think we should make in order to solve the problem?

we can add an empty object as the default value for the variables obj here :

        const [phrase, variables = {}] = Array.isArray(message) ? message : [message];

alternatively

we can modify the zipcode translation above to:

App/src/components/AddressForm.js

Line 106 in 9208c95

    
           errors.zipPostCode = ['privatePersonalDetails.error.incorrectZipFormat', {zipFormat: countryZipFormat}];

futhermore this snippet could be refactored to:

const trimmedZip = values.zipPostCode.trim().toUpperCase();
const zipValidation = countrySpecificZipRegex ? countrySpecificZipRegex.test(trimmedZip) : CONST.GENERIC_ZIP_CODE_REGEX.test(trimmedZip);
const isRequiredFulfilled = ValidationUtils.isRequiredFulfilled(values.zipPostCode.trim());

if (!zipValidation) {
    errors.zipPostCode = isRequiredFulfilled
        ? ['privatePersonalDetails.error.incorrectZipFormat', { zipFormat: countryZipFormat }]
        : 'common.error.fieldRequired';
}

Job added to Upwork: https://www.upwork.com/jobs/~01ae2a56928644ce4f

Reviewing label has been removed, please complete the "BugZero Checklist".

@s77rt

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: incorrect error message appear when enter Cyrillic letters into Zip field #35230

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

@s77rt requires payment automatic offer (Reviewer)
@dukenv0307 requires payment automatic offer (Contributor)

@s77rt

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified: [TS migration] Migrate 'Localize' lib to TypeScript #29742
The offending PR has been commented on: [TS migration] Migrate 'Localize' lib to TypeScript #29742 (comment)
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No. Typescript should help avoid those kind of bugs

@sonialiap

Issue is ready for payment but no BZ is assigned. @sonialiap you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@s77rt

@s77rt Reviewer $250 - paid ✔️
@dukenv0307 Contributor $250 - paid ✔️

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-20] [$250] Address – Incorrect error message appear when enter Cyrillic letters into Zip field #34668

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

alternatively

35 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-02-20] [$250] Address – Incorrect error message appear when enter Cyrillic letters into Zip field #34668

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

abzokhattab commented on Jan 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

alternatively

melvin-bot commented on Jan 18, 2024

35 remaining items

melvin-bot commented on Feb 13, 2024

melvin-bot commented on Feb 13, 2024

melvin-bot commented on Feb 13, 2024

s77rt commented on Feb 13, 2024

melvin-bot commented on Feb 20, 2024

sonialiap commented on Feb 21, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions