You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Tag - "Show more" button does not expand the list when clicked on #34761
Version Number: 1.4.27-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal team Slack conversation:
Action Performed:
Precondition: User is an employee of a Collect workspace that has 700 tags.
Navigate to workspace chat as employee.
Open manual request page.
Enter amount > Next > Show more.
Click Tag.
Scroll down to the bottom.
Click Show more.
Expected Result:
The list will expand.
Actual Result:
Nothing happens when clicking on Show more. This issue also happens in contact selection list when the list is long enough.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Tag - "Show more" button does not expand the list when clicked on[/-][+][$500] Tag - "Show more" button does not expand the list when clicked on[/+]on Jan 18, 2024
This is a regression from #32464. They add a focusin and out listener which will update disableEnterShortCut state. Every time we press down the button, the focusin is triggered and causes the show more button to remount and mount again because we pass it as an inline component, so the click is never registered.
📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
[-]Tag - "Show more" button does not expand the list when clicked on[/-][+][$500] Tag - "Show more" button does not expand the list when clicked on[/+]melvin-bot commentedon Jan 18, 2024
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 18, 2024
Job added to Upwork: https://www.upwork.com/jobs/~014922c638cdf27d55
melvin-bot commentedon Jan 18, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)kbecciv commentedon Jan 18, 2024
@greg-schroeder - #wave6-collect-submitters
gijoe0295 commentedon Jan 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Show more" button does not trigger on press.
What is the root cause of that problem?
SectionList'sListFooterComponentreceives a component whilerenderFooterContentis a function.App/src/components/OptionsList/BaseOptionsList.js
Line 293 in 31b19ea
What changes do you think we should make in order to solve the problem?
We need to manually call
renderFooterContent()before passing toListFooterComponenthere.What alternative solutions did you explore? (Optional)
NA
Result
Screen.Recording.2024-01-19.at.03.39.56-compressed.mov
abzokhattab commentedon Jan 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Show more" button does not trigger on press.
What is the root cause of that problem?
we wrongly pass the footer content as a function, not components values here:
That is why the OptionsList parses it as a function not react components:
App/src/components/OptionsSelector/BaseOptionsSelector.js
Lines 579 to 590 in 0ea199f
What changes do you think we should make in order to solve the problem?
we need to change it to:
Pujan92 commentedon Jan 18, 2024
Not sure then how #31447 was working.
bernhardoj commentedon Jan 19, 2024
This is a regression from #32464. They add a
focusinand out listener which will updatedisableEnterShortCutstate. Every time we press down the button, thefocusinis triggered and causes the show more button to remount and mount again because we pass it as an inline component, so the click is never registered.4 remaining items
melvin-bot commentedon Jan 23, 2024
📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Jan 23, 2024
📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
melvin-bot commentedon Feb 20, 2024
This issue has not been updated in over 15 days. @puneetlath, @Ollyws, @abzokhattab eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
puneetlath commentedon Feb 20, 2024
Whoops, looks like the automation failed on this one and @abzokhattab and @Ollyws need to be paid.
puneetlath commentedon Feb 20, 2024
@abzokhattab was paid.
@Ollyws you need to accept the offer: https://www.upwork.com/nx/wm/offer/28117886
Ollyws commentedon Feb 20, 2024
Accepted, thanks!
puneetlath commentedon Feb 20, 2024
All paid. Thanks y'all!