You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-07] Confirmation popover missing for Cancel Task #35035
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Here
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A It's just a basic case, we won't need separate regression tests here
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
cc: @jasperhuangg Let me know if you differ from above
Activity
melvin-bot commentedon Jan 24, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.DylanDylann commentedon Jan 24, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
no confirmation pop up
What is the root cause of that problem?
We don't have logic to implement it
App/src/pages/home/HeaderView.js
Line 141 in c0fbb97
What changes do you think we should make in order to solve the problem?
First we need to introduce new state
and new function
And add ConfirmModal COmponent
Then when clicking delete task we will update this state to true
App/src/pages/home/HeaderView.js
Line 141 in c0fbb97
We also need to close the modal if the current user loses permission to delete the task
What alternative solutions did you explore? (Optional)
We can consider to also display modal when user click mark as incomplete task in the header
Santhosh-Sellavel commentedon Jan 24, 2024
cc: @neonbhai here is the issue for the PR please update it in description
neonbhai commentedon Jan 24, 2024
@Santhosh-Sellavel Thank you. PR linked!
melvin-bot commentedon Jan 29, 2024
@jasperhuangg, @Santhosh-Sellavel Eep! 4 days overdue now. Issues have feelings too...
jasperhuangg commentedon Jan 29, 2024
We merged the contributor's PR that fixes this, not overdue!
11 remaining items
laurenreidexpensify commentedon Feb 8, 2024
@Santhosh-Sellavel please complete checklist thanks
Santhosh-Sellavel commentedon Feb 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
cc: @jasperhuangg Let me know if you differ from above
neonbhai commentedon Feb 13, 2024
@laurenreidexpensify hi, I think I'll be owed compensation as PR author for this issue. Please take a look 🙇
neonbhai commentedon Feb 16, 2024
@laurenreidexpensify friendly bump on this!
neonbhai commentedon Feb 20, 2024
@laurenreidexpensify please take a look when you can!
laurenreidexpensify commentedon Feb 21, 2024
@neonbhai pls apply here in Upwork - https://www.upwork.com/jobs/~01d28b4af3eb83de0d
neonbhai commentedon Feb 21, 2024
@laurenreidexpensify hi, could you please invite me to the job? As I'll have to buy connects to apply!
Upwork profile: https://www.upwork.com/freelancers/~01b1623e7bd66df3df
laurenreidexpensify commentedon Feb 22, 2024
@neonbhai sent!
laurenreidexpensify commentedon Feb 22, 2024
Payment Summary:
Contributor @neonbhai $500 paid in Upwork
Santhosh-Sellavel commentedon May 22, 2024
Requested on ND
JmillsExpensify commentedon May 31, 2024
$500 approved for @Santhosh-Sellavel