Repository navigation
[$500] LHN - Announce room on invited workspace member is not bold #35122
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.31-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- User A create workspace
- User A navigates to announce room> settings> set welcome message
- User A goes to Settings> Workspace> Members> Invite User B
- Login as User B
Expected Result:
Announce room on invited workspace member should be bold on LHN
Actual Result:
Announce room of invited workspace member is not bold on LHN, even green line on welcome message appears
Also, welcome message does not change on employee side when admin change the content of welcome message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6354010_1706142902654.Recording__1915.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~016aee40f12650c4a6
- Upwork Job ID: 1750329685857648640
- Last Price Increase: 2024-02-15
- Automatic offers:
- situchan | Contributor | 28129326
Activity
[-] LHN - Announce room on invited workspace member is not bold[/-][+][$500] LHN - Announce room on invited workspace member is not bold[/+]melvin-bot commentedon Jan 25, 2024
Job added to Upwork: https://www.upwork.com/jobs/~016aee40f12650c4a6
melvin-bot commentedon Jan 25, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 25, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (
External)jeremy-croff commentedon Jan 25, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
New workspaces for the user - does not show up as unread workspaces in LHN. They do get a notification.
What is the root cause of that problem?
We only show something as unread if the last read time is before the last visible is created here:
App/src/libs/ReportUtils.ts
Line 3517 in 0d0b0a8
And the announced message, is merely metadata on the report. Not an actual message.
What changes do you think we should make in order to solve the problem?
We should actually show all new channels as unread - this improves the customer experience by showing there's something new. Even if there are no messages in that channel.
We can make a small change here
App/src/libs/ReportUtils.ts
Line 3517 in 0d0b0a8
Once a user actually clicks on the report - it will be marked as read as the lastRead timestamp updates:
Sample experience with new code:
https://github.com/Expensify/App/assets/157416545/b615bf89-7f34-4fe6-86fa-3579a5638c0f
This also covers the announce use case in this issue.
What alternative solutions did you explore? (Optional)
dragnoir commentedon Jan 25, 2024
I think it should be fixed here #31748
Santhosh-Sellavel commentedon Jan 25, 2024
@dragnoir Can you elaborate on why?
Is that regression from #31748?
dragnoir commentedon Jan 25, 2024
@Santhosh-Sellavel check this #33881
it's the same issue here and the same problem. The suggested solution is the same in boath #33881 and #31748 but the issue is always there. The solution is not complete and need to handle all the UNREAD cases.
PR update: https://github.com/Expensify/App/pull/34551/files
Second issue proposal: #33881 (comment)
c+ note from the same issue #33881 (comment) and #33881 (comment)
but the PR submitted there #34551 is not tested well.
Santhosh-Sellavel commentedon Jan 27, 2024
Waiting for feedback #31748 (comment)
I'm unavailable next week, Please assign a new C+ Issue here if required while I am away, thanks!
#31748 (comment)
cc: @lschurr
77 remaining items
lschurr commentedon Apr 2, 2024
Asking for a volunteer in Slack here: https://expensify.slack.com/archives/C066HJM2CAZ/p1712079432372279
lschurr commentedon Apr 10, 2024
Haven't heard anything in the Slack thread - ideas on this one @thienlnam?
lschurr commentedon Apr 22, 2024
Anything on this one @thienlnam? Are we cool leaving this unassigned since it's a low priority?
thienlnam commentedon Apr 22, 2024
Nope, hasn't been a focus - I think it's fine to leave unassigned or even close for other priorities at this time
lschurr commentedon Apr 30, 2024
Going to close this as not a priority for now.