Skip to content

Android - Go to Expensify Classic icon is black instead of green #35468

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.34-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to Settings.

Expected Result:

Go to Expensify Classic icon is green.

Actual Result:

Go to Expensify Classic icon is black instead of green.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Activity

  1. github-actions commented on Jan 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jan 31, 2024

    @melvin-bot

    Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. situchan commented on Jan 31, 2024

    @situchan
    Contributor

    Seems like regression from #35097
    cc: @barttom

  4. rlinoz commented on Jan 31, 2024

    @rlinoz
    Contributor

    @barttom do you think you can raise a quick PR for this one?

  5. barttom commented on Jan 31, 2024

    @barttom
    Contributor

    @barttom do you think you can raise a quick PR for this one?

    @rlinoz I’ll try later today, at least tomorrow

  6. francoisl commented on Jan 31, 2024

    @francoisl
    Contributor

    This is currently blocking the deploy, so if we can't get a fix before tomorrow, let's revert the offending PR @rlinoz?

  7. rlinoz commented on Jan 31, 2024

    @rlinoz
    Contributor

    Yes, I will create the PR and request a CP, sorry for the delay.

  8. rlinoz commented on Jan 31, 2024

    @rlinoz
    Contributor
  9. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 31, 2024
  10. rlinoz commented on Jan 31, 2024

    @rlinoz
    Contributor

    Removing deploy blocker label since revert was CP'd

  11. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @rlinoz eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. rlinoz commented on Feb 26, 2024

    @rlinoz
    Contributor

    Closing this one in favor of #35018, as the fix proposal is in there and the PR is already in staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions