You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-15] [$500] Distance-By adding 2nd add stop user can delete empty location #35644
Version Number: 1.4.35 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation:
Note 3 dots on top right is not displayed to delete waypoint
Select a location
Navigate back and select add stop again
Now note, 3 dots on top right is displayed to delete waypoint before location is selected
Tap delete waypoint and note user can delete empty location.
Expected Result:
When adding first add stop, after adding location only 3 dots on top to delete waypoint displayed. Same behaviour must be displayed while user adding another stop point and before adding location 3dots to delete waypoint must not be shown and user must not be able to delete empty location.
Actual Result:
When adding first add stop, after adding location only 3 dots on top to delete waypoint displayed but when user add another stop point before adding location 3dots to delete waypoint shown and user can delete empty location.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Distance-By adding 2nd add stop user can delete empty location[/-][+][$500] Distance-By adding 2nd add stop user can delete empty location[/+]on Feb 2, 2024
What changes do you think we should make in order to solve the problem?
To fix this issue we can update this const and add waypointAddress
And if we have an address in currentWaypoint from transaction
Only then do we show the button
What changes do you think we should make in order to solve the problem?
I would check if there are more than two waypoints and if a current waypoint is already available e.g. the user wants to edit a waypoint. I think it doesnt makes sense to delete a waypoint which isnt saved.
Additionally we could also test if it is a stop waypoint. I think it doesnt makes sense to be able to delete start and finish endpoints. Editing should be enough for them.
distance.waypointDescription.stop
What alternative solutions did you explore? (Optional)
changed the title [-][$500] Distance-By adding 2nd add stop user can delete empty location[/-][+][HOLD for payment 2024-02-15] [$500] Distance-By adding 2nd add stop user can delete empty location[/+]on Feb 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Distance-By adding 2nd add stop user can delete empty location[/-][+][$500] Distance-By adding 2nd add stop user can delete empty location[/+]melvin-bot commentedon Feb 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0196d67f3a0a23173a
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.ZhenjaHorbach commentedon Feb 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance-By adding 2nd add stop user can delete empty location
What is the root cause of that problem?
The main problem with issue is that we check only waypoint count and regardless of the fullness of the input
We will show threeDots button
App/src/pages/iou/request/step/IOURequestStepWaypoint.js
Line 117 in 319d88f
What changes do you think we should make in order to solve the problem?
To fix this issue we can update this const and add waypointAddress
And if we have an address in currentWaypoint from transaction
Only then do we show the button
const shouldShowThreeDotsButton = waypointCount > 2 && waypointAddress;What alternative solutions did you explore? (Optional)
NA
pc6n commentedon Feb 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a second stop is added the user see the three dots button and can delete it .
(while its still empty)
What is the root cause of that problem?
We only check for the number of waypoints and show the button when there are more than 2 waypoints.
const shouldShowThreeDotsButton = waypointCount > 2;What changes do you think we should make in order to solve the problem?
I would check if there are more than two waypoints and if a current waypoint is already available e.g. the user wants to edit a waypoint. I think it doesnt makes sense to delete a waypoint which isnt saved.
Additionally we could also test if it is a stop waypoint. I think it doesnt makes sense to be able to delete start and finish endpoints. Editing should be enough for them.
distance.waypointDescription.stopWhat alternative solutions did you explore? (Optional)
NAfedirjh commentedon Feb 2, 2024
@ZhenjaHorbach Proposal looks good to me.
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
17 remaining items
[-][$500] Distance-By adding 2nd add stop user can delete empty location[/-][+][HOLD for payment 2024-02-15] [$500] Distance-By adding 2nd add stop user can delete empty location[/+]melvin-bot commentedon Feb 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Feb 20, 2024
@Beamanator, @kevinksullivan, @fedirjh, @ZhenjaHorbach Eep! 4 days overdue now. Issues have feelings too...
ZhenjaHorbach commentedon Feb 20, 2024
Oh )
It's time to pay ))
Beamanator commentedon Feb 21, 2024
True :D Bump @kevinksullivan for payout & @fedirjh for checklist 🙏
fedirjh commentedon Feb 21, 2024
BugZero Checklist:
kevinksullivan commentedon Feb 22, 2024
All set on payment