Repository navigation
[WAITING ON SITU TO FINISH CHECKLIST] [LOW] [Splits] [$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact #35665
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.35.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4263802
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Go to https://staging.new.expensify.com/
- Tap fab --- request money --- Scan
- Tap camera button and upload a picture
- Note first contact is not highlighted in Resents
- Now tap split and select the first contact from Resents
- Note, the contact is shown highlighted with green tick mark after selecting it
- Tap split button next to second contact and select it
Expected Result:
When user taps split button (no matter first or second selection), the row isn't always highlighted but only green tick is shown
Actual Result:
When user taps split button and select 2nd contact, only green tick shown, it is not highlighted like first contact after selection.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6364658_1706869108259.high.1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010e869b36a20a1985
- Upwork Job ID: 1753418217201557504
- Last Price Increase: 2024-02-09
- Automatic offers:
- situchan | Contributor | 0
- Krishna2323 | Contributor | 0
Activity
[-]IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact[/-][+][$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact[/+]melvin-bot commentedon Feb 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~010e869b36a20a1985
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (
External)melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kbecciv commentedon Feb 2, 2024
We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify
allgandalf commentedon Feb 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tapping split button & selecting 2nd contact are not highlighted like 1st contact
What is the root cause of that problem?
We only highlight/ Focus the top index element.
App/src/components/SelectionList/BaseSelectionList.tsx
Lines 223 to 231 in a0614e9
What changes do you think we should make in order to solve the problem?
Update the function to highlight all the selected participants
What alternative solutions did you explore? (Optional)
N/A
Some Thoughts:
I think this is intended and not a bug, when on laptop, if we use keyboard down button then the same focus moves down the list.Anyway, if this feels like a bug would like to solve this
jliexpensify commentedon Feb 5, 2024
@GandalfGwaihir regarding your comment:
I think the bug is that when you select a second person, the first person is still highlighted. I agree that the focus should move down the list, but it should then highlight the 2nd person instead, as it's the most recently selected.
@kbecciv is this essentially what you are saying?
jliexpensify commentedon Feb 5, 2024
I think this should actually go in #vip-split: https://expensify.slack.com/archives/C05RECHFBEW/p1707097628668729
Santhosh-Sellavel commentedon Feb 6, 2024
cc: @Expensify/design can you confirm whether this issue is bug or not?
115 remaining items
jliexpensify commentedon Apr 29, 2024
Thanks! Bumping @situchan to accept so I can pay everyone at once + complete checklist.
jliexpensify commentedon Apr 30, 2024
Bumped @situchan again
jliexpensify commentedon May 2, 2024
@situchan seems to be on leave.
jliexpensify commentedon May 6, 2024
Was hoping to pay both together but seems like @situchan is still on vacation.
@Krishna2323 apologies for the delay, have paid you.
[-][HOLD for payment 2024-04-25] [LOW] [Splits] [$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact[/-][+][WAITING ON SITU TO ACCEPT + CHECKLIST] [HOLD for payment 2024-04-25] [LOW] [Splits] [$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact[/+]jliexpensify commentedon May 16, 2024
Paid and job closed, waiting on the checklist
[-][WAITING ON SITU TO ACCEPT + CHECKLIST] [HOLD for payment 2024-04-25] [LOW] [Splits] [$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact[/-][+][WAITING ON SITU TO FINISH CHECKLIST] [LOW] [Splits] [$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact[/+]jliexpensify commentedon May 20, 2024
Bump @situchan - does the checklist need to be completed?
situchan commentedon May 20, 2024
Not able to find offending PR since this component was changed so many times.
This was caught during regression testing https://expensify.testrail.io/index.php?/tests/view/4263802 so no new regression test is needed.