Repository navigation
[Awaiting Payment March 4th] [$150] [Wave 8] [Ideal Nav] Change the global create and DM create tooltips to read Create #35677
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @muttmuure
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1706889045249449
Action Performed:
- Open NewDot on web/desktop
- Hover over the
+button in the bottom tab bar - Observe the tooltip reads
New - Click into a chat
- Hover over the
+button to the left of the composer - Observe the tooltip reads
Actions
Expected Result:
Standardise on displaying the tooltip in both places as: Create
Actual Result:
As described above, we have an inconsistency where we use New and Actions.
Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0121d4f02863128339
- Upwork Job ID: 1753465553597399040
- Last Price Increase: 2024-02-02
- Automatic offers:
- aimane-chnaif | Reviewer | 28149278
- esh-g | Contributor | 28149279
Activity
melvin-bot commentedon Feb 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0121d4f02863128339
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @zanyrenney (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.esh-g commentedon Feb 2, 2024
Proposal
Please re-state the issue we are trying to solve
Change the global create and DM create tooltips to read Create
Root cause
N/A
Solution
We need to modify translation here:
App/src/components/FloatingActionButton.tsx
Line 106 in e6ea03b
And here:
App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js
Line 279 in e6ea03b
To a new
common.createtranslation22 remaining items
melvin-bot commentedon Feb 7, 2024
📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
zanyrenney commentedon Feb 23, 2024
Can't we close this if merged? @trjExpensify
zanyrenney commentedon Feb 23, 2024
Or payouts still needed?
trjExpensify commentedon Feb 23, 2024
PR is only on staging, so next steps::
zanyrenney commentedon Feb 23, 2024
Ah, it looked 2 weeks old for me: @esh-g esh-g mentioned this issue 2 weeks ago
aimane-chnaif commentedon Feb 23, 2024
yes, PR should have been reached production already but this is edge case as we won't be deploying this week.
trjExpensify commentedon Feb 23, 2024
Right, we've had a deploy freeze because of the earnings call.
[-][$150] [Wave 8] [Ideal Nav] Change the global create and DM create tooltips to read `Create`[/-][+][Awaiting Payment March 4th] [$150] [Wave 8] [Ideal Nav] Change the global create and DM create tooltips to read `Create`[/+]trjExpensify commentedon Feb 27, 2024
PR is now on production as of yesterday. Adjusting the title to reflect the 7 day hold.
trjExpensify commentedon Mar 4, 2024
Payment summary as follows:
Paid out both, closing!