Repository navigation
[Awaiting Payment March 20th] [$500] Report - The conversation scrolls to the beginning when you open the settings menu #35763
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
- Open https://staging.new.expensify.com/
- Log in under your HT account A
- Navigate to a conversation with more messages
- Scroll to the top of your conversation history so that the last message is not visible
- Open settings via avatar
- Close the setting via the "Back" arrow
Expected Result:
When you close the settings menu, the conversation should not restart and scroll back to the beginning.
Actual Result:
The conversation scrolls to the beginning when you open the settings menu
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6366093_1706977070977.Recording__1272.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0154928522b8004b1d
- Upwork Job ID: 1753894702380920832
- Last Price Increase: 2024-03-18
- Automatic offers:
- akinwale | Reviewer | 0
Activity
[-]Report - The conversation scrolls to the beginning when you open the settings menu[/-][+][$500] Report - The conversation scrolls to the beginning when you open the settings menu[/+]melvin-bot commentedon Feb 3, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0154928522b8004b1d
melvin-bot commentedon Feb 3, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)melvin-bot commentedon Feb 3, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 3, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
91 remaining items
akinwale commentedon Mar 19, 2024
@trjExpensify #36888 was already a known issue prior to the PR being submitted as the performance problem was identified beforehand (context), so I think one regression deduction applies here.
adamgrzybowski commentedon Mar 19, 2024
@trjExpensify
I would merge the PR for scroll on the HOME page and ask somebody from SWM to use this code to create similar solution for the report screen scroll.
Do you want to create and issue for that?
mountiny commentedon Mar 20, 2024
Seems like this got handled well. We got an issue for the bottom tabs and PR to fix it going on
@trjExpensify with the chats I guess it depends, you can see Slack keeps the position. WhatsApp desktop does not though, I think we can explore how to solve this but we need to make sure it will solve well and would not hurt performance even if we would store the position for many reports (or put some limit on 10 latest visited reports for example.)
trjExpensify commentedon Mar 20, 2024
Ah okay, got it. Cool, updated the payment summary. Offers sent to you both!
[-][$500] Report - The conversation scrolls to the beginning when you open the settings menu[/-][+][Awaiting Payment March 20th] [$500] Report - The conversation scrolls to the beginning when you open the settings menu[/+]akinwale commentedon Mar 20, 2024
@trjExpensify Accepted. Thanks!
trjExpensify commentedon Mar 20, 2024
Yeah, maybe we can bring this out for a discussion in somewhere like #vip-vsb to decide what we want to do. I agree we don't want to take a performance hit, but I do think keeping the position will be desirable when we use this a lot for all of our business chat purposes where you're switching a lot.
trjExpensify commentedon Mar 20, 2024
Paid!
trjExpensify commentedon Mar 22, 2024
@sahilnagpal26 waiting for you to accept the offer.
trjExpensify commentedon Mar 25, 2024
@sahilnagpal26 paid. Closing!