[HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$500] 0 is showing up in black small font in split bill preview

@alitoshmatov

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.37-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @alitoshmatov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707150156382219

Action Performed:

Open group with 2 other accounts
Split bill
Scan receipt

Expected Result:

0 shouldn't show up like that for amount

Actual Result:

In split preview there is a zero showing small black font

Workaround:

UNknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01071057525b16cfaa
Upwork Job ID: 1754897944662765568
Last Price Increase: 2024-02-06
Automatic offers:

situchan | Contributor | 28146438

Job added to Upwork: https://www.upwork.com/jobs/~01071057525b16cfaa

@mananjadhav

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

0 is showing up in black small font in split bill preview

What is the root cause of that problem?

App/src/components/ReportActionItem/MoneyRequestPreview.tsx

Lines 324 to 332 in ebc2b7d

    
           {isBillSplit && participantAccountIDs.length > 0 && requestAmount && requestAmount > 0 && ( 
        
               <Text style={[styles.textLabel, styles.colorMuted, styles.ml1, styles.amountSplitPadding]}> 
        
                   {translate('iou.amountEach', { 
        
                       amount: CurrencyUtils.convertToDisplayString( 
        
                           IOUUtils.calculateAmount(isPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount, requestCurrency ?? ''), 
        
                           requestCurrency, 
        
                       ), 
        
                   })} 
        
               </Text>

When requestAmount is 0, this is rendered as 0 because 0 && <Text> = 0

What changes do you think we should make in order to solve the problem?

change requestAmount && to !!requestAmount &&

@trjExpensify

This is deploy blocker as this crashes on android/iOS. Not happening on production.
cc: @trjExpensify

This is a known issue
#34564 (comment)

@VickyStash

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[TS Migration] Follow-up PR to fix crash on MoneyRequestPreview #35916

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

@VickyStash does not require payment (Contractor)
@situchan requires payment automatic offer (Contributor)
@alitoshmatov requires payment (Needs manual offer from BZ)

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@VickyStash

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[TS Migration] Follow-up PR to fix crash on MoneyRequestPreview #35916

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

@VickyStash does not require payment (Contractor)
@situchan requires payment automatic offer (Contributor)
@alitoshmatov requires payment (Needs manual offer from BZ)

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@situchan

@situchan confirming there's nothing for us to do on this regression issue, right? We can close it out as the OG issue is where any payment and what not will happen?

I am eligible here as I was not involved in offending PR

Ah cool, okay. Settled up $500 with you for the review. Closing!

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$500] 0 is showing up in black small font in split bill preview #35915

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

42 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{isBillSplit && participantAccountIDs.length > 0 && requestAmount && requestAmount > 0 && (
	<Text style={[styles.textLabel, styles.colorMuted, styles.ml1, styles.amountSplitPadding]}>
	{translate('iou.amountEach', {
	amount: CurrencyUtils.convertToDisplayString(
	IOUUtils.calculateAmount(isPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount, requestCurrency ?? ''),
	requestCurrency,
	),
	})}
	</Text>

[HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$500] 0 is showing up in black small font in split bill preview #35915

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 6, 2024

melvin-bot commented on Feb 6, 2024

melvin-bot commented on Feb 6, 2024

mkhutornyi commented on Feb 6, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

mkhutornyi commented on Feb 6, 2024

ZhenjaHorbach commented on Feb 6, 2024

42 remaining items

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 8, 2024

melvin-bot commented on Feb 8, 2024

trjExpensify commented on Feb 15, 2024

situchan commented on Feb 15, 2024

trjExpensify commented on Feb 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions