Repository navigation
[Performance] CMD + K is slow and laggy #3601
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- While using e.cash use the cmd+k command
- Type on the search field
Expected Result:
App should be fast and search should be responsive as soon as the command is used
Actual Result:
Cmd + K is super slow and laggy and is locking up the whole app when used. Search functionality seems completely broken (on desktop staging
Workaround:
No workaround found.
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App ✔️
Mobile Web
Version Number: 1.0.68-4
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
(Unable to add video since I don't have MacOS)
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/168172
Upwork job: https://www.upwork.com/jobs/~015673ac7d22fbbd42
From @puneetlath https://expensify.slack.com/archives/C01GTK53T8Q/p1623719515341400
ISSUE: cmd + K is super slow and laggy and is locking up the whole app when used. Search functionality seems completely broken (on desktop staging v1.0.68-4)
Activity
MelvinBot commentedon Jun 15, 2021
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Jun 17, 2021
Triggered auto assignment to @jliexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.jliexpensify commentedon Jun 17, 2021
Hi @isagoico - I wasn't able to test this on your version, as I have 1.0.71-0. Here's a video of the search feature - it seems to be working and I don't think it's slow (personally):
2021-06-18_09-13-30.mp4
Do you think we can close this GH?
marcaaron commentedon Jun 18, 2021
Investigating this now.
27 remaining items
nickmurray47 commentedon Jun 30, 2021
@Looxor the PR created several regressions that were linked in this PR #3824 that reverted your original one. Can you please submit a follow-up PR if you'd still like to complete this one?
Merge pull request #3824 from Expensify/revert-3760-thibault-FixSearc…
Looxor commentedon Jul 7, 2021
@nickmurray47 , Can you please provide a demo user credential to check "Search" and "New chat" with many users?
I have one, but it's only one user and I have no idea to create members for testing.
Thank you.
nickmurray47 commentedon Jul 7, 2021
@Looxor can you please post the same question in the #expensify-open-source channel first? Someone there might already have set up an account for you to use. If no one is available to assist then I can help from there. Thanks.
Looxor commentedon Jul 8, 2021
@nickmurray47 ,
I didn't join the Slack channels so I sent an email "Slack Channel Invite" to contributors@expensify.com (as mentioned in guideline).
But I didn't get any invitation from there.
Can you please check this for me?
nickmurray47 commentedon Jul 8, 2021
@Looxor just saw your request and I made the Slack Channel invite request on our end. You should be in the channel shortly. Let me know if you have any other questions.
Looxor commentedon Jul 10, 2021
Dear @nickmurray47 ,
It seems that I found a way to solve this problem without reverting original sources.
But, can you please provide me your testing demo account?
I need to confirm your symptom on my side again.
I tried to update local storage for moc data, and there was no problem on my side.
Looxor commentedon Jul 13, 2021
Hi @jliexpensify,
I am investing in this issue, and it appears to be slow on my side.
Can you please provide me the credentials (email/password) which are used for this demo?
#3601 (comment)
NicMendonca commentedon Jul 13, 2021
@Looxor that appears to be @jliexpensify's actual account, so he's not going to be able to share those credentials with you.
Can you please describe what is blocking? Is it a demo account?
Looxor commentedon Jul 13, 2021
Hi @NicMendonca , thank you for your reply.
Oh, is it an actual one? I thought it was a demo account because the video showed the staging version app.
Anyway, I need to test the app using a bunch of users, but for me, only one user (Conceige) showed up.
NicMendonca commentedon Jul 13, 2021
@Looxor thanks for that context! Can you please open up this dialogue in #expensify-open-source to see if someone has credentials or a workaround for you?
timszot commentedon Jul 13, 2021
Left a comment on the PR, I ran some tests using my account so we can evaluate from there.
[-]Desktop - CMD + K is slow and laggy[/-][+][Performance] CMD + K is slow and laggy[/+]NicMendonca commentedon Jul 20, 2021
This issue is not longer a priority. Ended contract in Upwork. Thanks everyone!