[HOLD for payment 2024-02-26] Simplify native attachment gallery

@kadiealexander

Internal tracking issue for cleaning up the native attachment gallery/carousel.

In a recent succession of PRs a lot of work has happened on the native attachment carousel and we need to cleanup the code a bit.

Recent PRs were:

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d28994a18233cccb
Upwork Job ID: 1755254749373579264
Last Price Increase: 2024-02-07

Issue Owner

Current Issue Owner: @kadiealexander

@tgolen

@tgolen I can't submit the labels

Add the labels engineering, daily, internal, bug

Job added to Upwork: https://www.upwork.com/jobs/~01d28994a18233cccb

@rushatgabhane

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@hannojg

@hannojg I added the labels!

Big thanks!

@kirillzyusko

@kirillzyusko Can you please comment here so the issue can get assigned to you? Thanks!

@hannojg

@hannojg yes, sure

I can work on this ticket

Reviewing label has been removed, please complete the "BugZero Checklist".

@kirillzyusko

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Simplify native attachment gallery paging context and improve code #34080

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

@kirillzyusko does not require payment (Contractor)
@mollfpr requires payment (Needs manual offer from BZ)

@mollfpr

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@kirillzyusko

Payment Summary

Upwork Job

Contributor: @kirillzyusko is from an agency-contributor and not due payment
ROLE: @mollfpr paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@kadiealexander)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1755254749373579264/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@mollfpr

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. This is an improvement for the attachment gallery components.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No need new regression step. We already have the test rail for attachment under Conversation > Attachments and Downloads.

@kadiealexander

@kadiealexander Could you give the payment summary for the manual request in NewDot? Thank you!

@mollfpr

Payouts due:

Contributor+: $500 @mollfpr via manual request

@mollfpr

$500 approved for @mollfpr based on summary above.

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-26] Simplify native attachment gallery #36034

12 remaining items

Payment Summary

BugZero Checklist (@kadiealexander)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-02-26] Simplify native attachment gallery #36034

Description

Activity

hannojg commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

pecanoro commented on Feb 7, 2024

hannojg commented on Feb 7, 2024

hannojg commented on Feb 8, 2024

kirillzyusko commented on Feb 8, 2024

12 remaining items

melvin-bot commented on Feb 19, 2024

melvin-bot commented on Feb 19, 2024

melvin-bot commented on Feb 19, 2024

melvin-bot commented on Feb 26, 2024

Payment Summary

BugZero Checklist (@kadiealexander)

mollfpr commented on Feb 27, 2024

mollfpr commented on Feb 27, 2024

kadiealexander commented on Feb 27, 2024

JmillsExpensify commented on Mar 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions