Repository navigation
mWeb - Safari- Page gets distorted tapping add phone number in profile #3604
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to staging.expensify.cash and login
- Tap avatar
- Tap profile
- Tap add phone number
Expected Result:
Add phone number page opens to enter phone number and password
Actual Result:
Page looks distorted, Partially displaying the add phone number page
Workaround:
Unknown
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web ✔️
Version Number: 1.0.69-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5114980_IMG_5863.mp4
Expensify/Expensify Issue URL:
Activity
OSBotify commentedon Jun 16, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Jun 16, 2021
Triggered auto assignment to @NikkiWines (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.NikkiWines commentedon Jun 16, 2021
Can reproduce on a sim, going to look into what commit might've introduced this:
NikkiWines commentedon Jun 16, 2021
Exists for me on commit
c5e6da221(which is the merge commit for #3193) but doesn't exist one4bd83e23, the commit before it. Looks likesrc/pages/settings/AddSecondaryLoginPage.jswas modified in that PR too.cc: @roryabraham looks like @parasharrajat's PR may have introduced this
parasharrajat commentedon Jun 16, 2021
Thanks, @NikkiWines I think the same. There are issues on the safari M-web and all other platforms are good. I will look into it.
roryabraham commentedon Jun 17, 2021
@parasharrajat Any information here?
parasharrajat commentedon Jun 17, 2021
Checking all the safari issues now. I will try to fix them one by one.
tgolen commentedon Jun 22, 2021
@parasharrajat this issue is blocking deploys and should be the absolute top priority. What is the status of this? How can I help?
parasharrajat commentedon Jun 22, 2021
Ok. I'll take it first. I think I know what I need to do here.
roryabraham commentedon Jun 22, 2021
@parasharrajat and I talked about this a bit 1:1 ... PR is up
TL;DR it works perfectly on simulator, but on the actual iPhone the keyboard may not open, despite the input being focused correctly. But it does solve this problem.
isagoico commentedon Jun 23, 2021
Tested this on iOS and confirmed it's working on 1.0.73-2 🎉
