Repository navigation
Chat - To enter link name in multi line, tapping enter key changes link to text #36180
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.39.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4293571
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Go to https://staging.new.expensify.com/home
- Tap on a report
- Paste a link and send the message
- Long press and tap edit comment
- Select link url name part and delete it
- Enter a text in url name part and tap enter
Expected Result:
Deleting url name part, entering a text & tapping enter key to enter link name in multi line, must not change link to text.
Actual Result:
Deleting url name part, entering a text & tapping enter key to enter link name in multi line, changes link to text.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
github-actions commentedon Feb 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 8, 2024
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Feb 8, 2024
We think that this bug might be related #vip-vsb
CC @quinthar
tgolen commentedon Feb 8, 2024
This looks like probably an issue from the live markdown feature.
tgolen commentedon Feb 8, 2024
@Skalakid Could you help verify if this is a bug with live markdown or not?
roryabraham commentedon Feb 8, 2024
According to GitHub newlines can be in the text part of a link:
valid link
another valid
link
roryabraham commentedon Feb 8, 2024
Interestingly, newlines in links work ok, it's just if you remove the text part of an existing link and then insert a newline into what remains that this happens.
Skalakid commentedon Feb 9, 2024
@tgolen Yes it is connected with live markdown parsing system, just looking into it
robertKozik commentedon Feb 9, 2024
@Skalakid it's probably connected with parser - input is not the same as output and we are not highlighting then
thienlnam commentedon Feb 9, 2024
We've reverted the offending PR #35837, so this is no longer a blocker
robertKozik commentedon Feb 13, 2024
Cannot reproduce it on staging, will look into it further
tgolen commentedon Feb 16, 2024
I'm going to close this since the PR which caused the regression was reverted.