Repository navigation
[HOLD for payment 2024-08-02] [$500] "Go back to home page" in LHN doesn't work when WS deleted from secondary device #36266
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Prerequisite: Main and secondary devices logged in to the same user in New Expensify
- [Main device] Create new Workspace
- [Main device] Navigate to Members
- [Secondary device] Delete Workspace created in Main device
- [Main device] Click on "Go back to home page" in LHN
Expected Result:
User should be redirected to Workspaces settings.
Actual Result:
Nothing happens when user clicks on "Go back to home page" in LHN
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6373526_1707483142078.2024-02-08_23-53-05.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0170390297c07d44ce
- Upwork Job ID: 1755993628416561152
- Last Price Increase: 2024-02-16
Activity
[-]"Go back to home page" in LHN doesn't work when WS deleted from secondary device[/-][+][$500] "Go back to home page" in LHN doesn't work when WS deleted from secondary device[/+]melvin-bot commentedon Feb 9, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0170390297c07d44ce
melvin-bot commentedon Feb 9, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)melvin-bot commentedon Feb 9, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kavimuru commentedon Feb 9, 2024
We think that this bug might be related to #wave8-collect-admins
jeremy-croff commentedon Feb 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Go back to home page link is not taking you back home
What is the root cause of that problem?
The link actions is defined to dismiss the modal it's expected to be in. The Component is FullPageNotFoundView. however we are not in a modal. This is part of navigation previous navigation changes.
What changes do you think we should make in order to solve the problem?
We should update the link action from
onLinkPress = () => Navigation.dismissModal()to() => Navigation.goBack(ROUTES.HOME)This way the action semantically matches the user text, and can resolve the navigation action without erroring.
What alternative solutions did you explore? (Optional)
jeremy-croff commentedon Feb 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Go back to home page link is not taking you back to settings
What is the root cause of that problem?
The link is not doing anything because the button action is trying to dismiss a modal. The Component is this logic is in is, FullPageNotFoundView. however we are not in a modal. This is part of navigation previous navigation changes.
What changes do you think we should make in order to solve the problem?
If we want to navigate back to the workspace settings, we want it to be specific to this flow as not all FullPageNotFoundView will want to go to settings.
We should update the link action from
onLinkPress = () => Navigation.dismissModal()to() => Navigation.goBack(ROUTES.HOME, true),and add a new notFound link text with copy to navigate back generically to the previous screen (and not have it say home page) if we want to go back the the previous screen, like settings.
This true boolean on goBack uses ROUTES.HOME as a fallback if there's no previous stack to goBack to.
55 remaining items
melvin-bot commentedon Apr 18, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$500] "Go back to home page" in LHN doesn't work when WS deleted from secondary device[/-][+][HOLD for payment 2024-08-02] [$500] "Go back to home page" in LHN doesn't work when WS deleted from secondary device[/+]melvin-bot commentedon Jul 26, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 26, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: