[$500] Clicking on room name while loading crashes the app

@getusha

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.39-0
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707493474003029

Action Performed:

1.Go offline
2.Open a workspace
3.go to announce room
4.make sure the loading skeleton is shown
5.Press on the room header

Expected Result:

Opens details page

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-02-09.at.6.44.18.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cd42193c8752a37e
Upwork Job ID: 1755996151032115200
Last Price Increase: 2024-02-09

Job added to Upwork: https://www.upwork.com/jobs/~01cd42193c8752a37e

@situchan

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@dylanexpensify

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

i have solved this problem countless times in my own android app so i know the solution

@Natan-Asrat

📣 @Natan-Asrat! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on room name while loading crashes the app

What is the root cause of that problem?

Strange that I cannot reproduce on dev
But easy on the prod

Looks like we try to get a description from the report (Which is undefined )

What changes do you think we should make in order to solve the problem?

I think the problem related to this line

App/src/pages/ReportDetailsPage.tsx

Line 73 in 4f9d415

    
           const shouldShowReportDescription = isChatRoom && (canEditReportDescription || report.description !== '');

So we can update this line like

const shouldShowReportDescription = isChatRoom && (canEditReportDescription || report?.description !== '');

I think this fix makes sense because I noticed that in ReportDetailsPage we use report?. almost everywhere and strange that we ignore it here

Also, we have a similar place here

App/src/pages/ReportDetailsPage.tsx

Line 249 in 4f9d415

title={report.description}

So I think it's good to check all places where we use values fromreport

What alternative solutions did you explore? (Optional)

NA

Contributor details
Your Expensify account email: natsceo@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~014ae4361b802854c6

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

But we still have this line )
https://github.com/Expensify/App/pull/35153/files#diff-409b0e2fb439856e9897b808014031ce244a427d116ed30f37a2e0117599adc4R73

Regression ~~from~~ fixed by issue #25195 , PR #35153 (merged 2h ago).
This is why it's not reproducible on dev w/ latest main and only on staging / production.

@ikevin127

Regression from issue #25195 , PR #35153 (merged 2h ago).

@ikevin127 you mean fixed by #25195?
Seems like that PR fixed crash, not caused crash

Regression from issue #25195 , PR #35153 (merged 2h ago).

This bug is in production)
I doubt they merged this branch in prod so quickly

@ZhenjaHorbach

@ZhenjaHorbach if you find the case of report being undefined or null, we can continue this issue.
Otherwise can be closed.

Regression seems to be from #34150 and #25195 fixed the crash.

@ZhenjaHorbach

@ZhenjaHorbach if you find the case of report being undefined or null, we can continue this issue. Otherwise can be closed.

Report from ONYX can be null )

I think it's easier to add a hold )
And wait when this PR will be in prod or staging
#35153

But it confuses me that we use report?. everywhere in this component
That is, it is expected that the report may be undefined or null
But ignore a few places

yes, Onyx values are optional and agree that we should use optional chaining everywhere.

#35153 hit staging.
Now crash doesn't happen on staging.

@ZhenjaHorbach

@ZhenjaHorbach thoughts on #36271 (comment)?

@ZhenjaHorbach

@ZhenjaHorbach thoughts on #36271 (comment)?

I tried to reproduce the problem associated with this line)

App/src/pages/ReportDetailsPage.tsx

Line 73 in 4f9d415

    
           const shouldShowReportDescription = isChatRoom && (canEditReportDescription || report.description !== '');

But I didn't succeed)
And there are no more crashes

@dylanexpensify

ok @dylanexpensify let's close as fixed

Navigation Menu

Repository navigation

[$500] Clicking on room name while loading crashes the app #36271

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

1 remaining item

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] Clicking on room name while loading crashes the app #36271

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 9, 2024

melvin-bot commented on Feb 9, 2024

melvin-bot commented on Feb 9, 2024

Natan-Asrat commented on Feb 9, 2024

melvin-bot commented on Feb 9, 2024

ZhenjaHorbach commented on Feb 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Natan-Asrat commented on Feb 9, 2024

melvin-bot commented on Feb 9, 2024

1 remaining item

ZhenjaHorbach commented on Feb 9, 2024

ikevin127 commented on Feb 9, 2024

situchan commented on Feb 9, 2024

ZhenjaHorbach commented on Feb 9, 2024

situchan commented on Feb 9, 2024

Pujan92 commented on Feb 9, 2024

ZhenjaHorbach commented on Feb 9, 2024

situchan commented on Feb 9, 2024

situchan commented on Feb 12, 2024

situchan commented on Feb 12, 2024

ZhenjaHorbach commented on Feb 12, 2024

situchan commented on Feb 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions