Skip to content

[HOLD for payment 2024-03-06] [$250] Strikethrough line is white on links and emails #36349

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Log in to New Expensify
  2. Nagivate to any chat
  3. Send any email or link with strikethrough markdown

Expected Result:

Strikethrough line should match the color of links and emails.

Actual Result:

Strikethrough line is white.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6376813_1707754899905.2024-02-12_17-20-25.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190109e65c0e5c4d0
  • Upwork Job ID: 1757082391060185088
  • Last Price Increase: 2024-02-12
  • Automatic offers:
    • mollfpr | Contributor | 0
    • mkhutornyi | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 12, 2024
  2. changed the title [-]Strikethrough line is white on links and emails[/-] [+][$500] Strikethrough line is white on links and emails[/+] on Feb 12, 2024
  3. melvin-bot commented on Feb 12, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 12, 2024
  5. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

  6. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 12, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 38 remaining items

  9. changed the title [-][$250] Strikethrough line is white on links and emails[/-] [+][HOLD for payment 2024-03-06] [$250] Strikethrough line is white on links and emails[/+] on Mar 1, 2024
  10. garrettmknight commented on Mar 6, 2024

    @garrettmknight
    Contributor

    Payment Summary

  11. mollfpr commented on Mar 7, 2024

    @mollfpr
    Contributor

    @garrettmknight Requested in NewDot! I'll complete the checklist soon.

  12. garrettmknight commented on Mar 8, 2024

    @garrettmknight
    Contributor

    Cool, dropping to weekly.

  13. mollfpr commented on Mar 9, 2024

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

    #35462

    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    https://github.com/Expensify/App/pull/35462/files#r1518590135

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    I think the regression step should be good and we also have a checklist to check the generic component.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    We can a case for strikethrough an link/email and verify the strikethrough color match the link color. https://expensify.testrail.io/index.php?/cases/view/2950395

  14. garrettmknight commented on Mar 11, 2024

    @garrettmknight
    Contributor

    TestRail update in - just up to you to submit for payment now!

  15. JmillsExpensify commented on Mar 12, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @mollfpr based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions