You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-06] [$250] Strikethrough line is white on links and emails #36349
Version Number: 1.4.40-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Log in to New Expensify
Nagivate to any chat
Send any email or link with strikethrough markdown
Expected Result:
Strikethrough line should match the color of links and emails.
Actual Result:
Strikethrough line is white.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] Strikethrough line is white on links and emails[/-][+][HOLD for payment 2024-03-06] [$250] Strikethrough line is white on links and emails[/+]on Mar 1, 2024
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
I think the regression step should be good and we also have a checklist to check the generic component.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
[-]Strikethrough line is white on links and emails[/-][+][$500] Strikethrough line is white on links and emails[/+]melvin-bot commentedon Feb 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0190109e65c0e5c4d0
melvin-bot commentedon Feb 12, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (
External)melvin-bot commentedon Feb 12, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
38 remaining items
[-][$250] Strikethrough line is white on links and emails[/-][+][HOLD for payment 2024-03-06] [$250] Strikethrough line is white on links and emails[/+]garrettmknight commentedon Mar 6, 2024
Payment Summary
mollfpr commentedon Mar 7, 2024
@garrettmknight Requested in NewDot! I'll complete the checklist soon.
garrettmknight commentedon Mar 8, 2024
Cool, dropping to weekly.
mollfpr commentedon Mar 9, 2024
#35462
https://github.com/Expensify/App/pull/35462/files#r1518590135
I think the regression step should be good and we also have a checklist to check the generic component.
We can a case for strikethrough an link/email and verify the strikethrough color match the link color. https://expensify.testrail.io/index.php?/cases/view/2950395
garrettmknight commentedon Mar 11, 2024
TestRail update in - just up to you to submit for payment now!
JmillsExpensify commentedon Mar 12, 2024
$250 approved for @mollfpr based on summary.