Skip to content

[HOLD for payment 2024-03-11] Distance - App refreshes when hitting Enter on empty waypoint editor #36363

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Request money > Distance.
  3. Click Start.
  4. Hit Enter on keyboard.
    Note that the page refreshes.

Expected Result:

App returns to the distance request page.

Actual Result:

App refreshes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6377102_1707765277552.20240213_014106.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c78c122e47f0026b
  • Upwork Job ID: 1757134919273578496
  • Last Price Increase: 2024-02-12
  • Automatic offers:
    • cubuspl42 | Contributor | 0

Activity

  1. github-actions commented on Feb 12, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Feb 12, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave5-free-submitters
    CC @dylanexpensify

  4. blimpich commented on Feb 12, 2024

    @blimpich
    Contributor

    Not a blocker.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 12, 2024
  6. changed the title [-]Distance - App refreshes when hitting Enter on empty waypoint editor[/-] [+][$500] Distance - App refreshes when hitting Enter on empty waypoint editor[/+] on Feb 12, 2024
  7. melvin-bot commented on Feb 12, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 12, 2024
  9. 20 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 4, 2024
  11. changed the title [-]Distance - App refreshes when hitting Enter on empty waypoint editor[/-] [+][HOLD for payment 2024-03-11] Distance - App refreshes when hitting Enter on empty waypoint editor[/+] on Mar 4, 2024
  12. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-11. 🎊

    For reference, here are some details about the assignees on this issue:

  14. jakub-trzebiatowski commented on Mar 5, 2024

    @jakub-trzebiatowski
    Contributor

    No payment for me, we handled this as a regression

  15. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  16. abekkala commented on Mar 11, 2024

    @abekkala
    Contributor

    Hi @blimpich based on this comment:
    Screenshot 2024-03-11 at 3 03 44 PM

    Does this particular issue need payment? It seems like payments are being handed via #31433 correct?

    can this one just be closed? or do I need to even be assigned?

  17. blimpich commented on Mar 11, 2024

    @blimpich
    Contributor

    👍 Correct yes this one can just be closed. I'll close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions