Skip to content

[HOLD for payment 2024-02-20] [$500] The "Enter" key does not work when editing the "Description" and "Merchant" fields #36370

New issue
New issue
Closed
Closed
[HOLD for payment 2024-02-20] [$500] The "Enter" key does not work when editing the "Description" and "Merchant" fields#36370
Assignees
rushatgabhanejoekaufmanexpensifyshubham1206agrahayata-suenaga
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Description

@m-natarajan
m-natarajan
opened on Feb 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Configure the OldDot administrator account, invite an employee and include multiple categories and tags
https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0

Steps:

  1. Open https://staging.new.expensify.com/

  2. Log in with the employee's login

  3. Click on FAB

  4. Select "Request money"

  5. Deposit any amount

  6. Click on the "Next" button

  7. Select Group Policy WS

  8. Select any category or tag

  9. Click the Merchant or Description field

  10. Entry any data

  11. Press the "Enter" key

Expected Result:

Pressing the "Enter" key should save the data in the "Description" and "Merchant" fields and return to the IOU menu

Actual Result:

The Enter key does not work when editing the Description and Merchant fields after selecting a Category or Tag

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6377180_1707768877101.Recording__1328.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012366b11cbf8f59eb
  • Upwork Job ID: 1757144388262604800
  • Last Price Increase: 2024-02-12
  • Automatic offers:
    • shubham1206agra | Contributor | 0

Activity

  1. m-natarajan
    added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 12, 2024

  2. melvin-bot commented on Feb 12, 2024

    @melvin-bot
    melvin-botBot
    on Feb 12, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~012366b11cbf8f59eb

  3. melvin-bot
    changed the title [-]The "Enter" key does not work when editing the "Description" and "Merchant" fields[/-] [+][$500] The "Enter" key does not work when editing the "Description" and "Merchant" fields[/+] on Feb 12, 2024
  4. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 12, 2024
  5. melvin-bot
    assigned
    rushatgabhane
    on Feb 12, 2024

  6. melvin-bot commented on Feb 12, 2024

    @melvin-bot
    melvin-botBot
    on Feb 12, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  7. melvin-bot
    assigned
    joekaufmanexpensify
    on Feb 12, 2024

  8. melvin-bot commented on Feb 12, 2024

    @melvin-bot
    melvin-botBot
    on Feb 12, 2024 – with Melvin Bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Feb 12, 2024

  10. github-actions commented on Feb 12, 2024

    @github-actions
    github-actionsBot
    on Feb 12, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  11. 13 remaining items

  12. shubham1206agra commented on Feb 13, 2024

    @shubham1206agra
    shubham1206agra
    on Feb 13, 2024
    Contributor

    @Beamanator PR is up.

  13. jakub-trzebiatowski commented on Feb 13, 2024

    @jakub-trzebiatowski
    jakub-trzebiatowski
    on Feb 13, 2024
    Contributor

    @Beamanator PR is C+ approved

  14. Beamanator commented on Feb 13, 2024

    @Beamanator
    Beamanator
    on Feb 13, 2024
    Contributor

    PR merged & is being CP'd to staging 🙏

  15. Beamanator commented on Feb 13, 2024

    @Beamanator
    Beamanator
    on Feb 13, 2024
    Contributor

    This also looks fixed on staging! 🚀

  16. Beamanator
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 13, 2024
  17. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Feb 13, 2024
  18. melvin-bot
    changed the title [-][$500] The "Enter" key does not work when editing the "Description" and "Merchant" fields[/-] [+][HOLD for payment 2024-02-20] [$500] The "Enter" key does not work when editing the "Description" and "Merchant" fields[/+] on Feb 13, 2024
  19. melvin-bot
    removed
    ReviewingHas a PR in review
    on Feb 13, 2024

  20. melvin-bot commented on Feb 13, 2024

    @melvin-bot
    melvin-botBot
    on Feb 13, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  21. melvin-bot commented on Feb 13, 2024

    @melvin-bot
    melvin-botBot
    on Feb 13, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-20. 🎊

    For reference, here are some details about the assignees on this issue:

  22. melvin-bot commented on Feb 13, 2024

    @melvin-bot
    melvin-botBot
    on Feb 13, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
    • [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  23. shubham1206agra commented on Feb 14, 2024

    @shubham1206agra
    shubham1206agra
    on Feb 14, 2024
    Contributor

    @hayata-suenaga Can you close this issue? There's no pending payment here

  24. hayata-suenaga
    closed this as completedon Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions