You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[LOW] [Splits] [$500] Chat - Green line is not present correctly on the first unread system message #36399
changed the title [-]Chat - Green line is not present correctly on the first unread system message[/-][+][$500] Chat - Green line is not present correctly on the first unread system message[/+]on Feb 13, 2024
@joekaufmanexpensify I did a first investigation, was a bit hard to reproduce it, the only way I could, it is going into the chat before the Date modification arrives. Even tho, the logic is working ok, because the user opens the chat before the message arrives, meaning that is looking at the chat before the Date modification shows up, so the green line it is showing to the last message. Will try to explain in with some steps what it is going on:
Issue 1)
User B
User A
send money request
Receives it (not focus)
Modify Description
Receives it (not focus)
Modify Merchant
Receives it (not focus)
Modify Date
Focus the chat, green line is placed at Merchant message
__
Receives the Date Modification
So the green line is showing at the right place, because the report lastReadTime is not < date reportAction create value
Issue 2)
What I saw, that sometimes the report lastReadTime has undefined, so the green line it is showing at the top
So to fix this one into the function calculateUnreadMarker we should add a condition to skip the calculation of the marker when the report.lastReadTime is not set
For issue 1, yes, do nothing.
issue 2: will be doing the same steps but faster. You will see in the next video that all the messages are there already but the green line is placed at the top
Is the bug there only because you had the two windows open enabling you to do this more quickly? And if you were doing it in one window, timing wise, it would not happen?
If so, I'm not convinced it's worth doing anything to change that. It doesn't feel super likely to be that many/anyone will be doing that.
Is the bug there only because you had the two windows open enabling you to do this more quickly?
I think yes, I couldn't reproduce it using the app in a normal way
Activity
melvin-bot commentedon Feb 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0117ea985dcf52297d
[-]Chat - Green line is not present correctly on the first unread system message[/-][+][$500] Chat - Green line is not present correctly on the first unread system message[/+]melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.ikevin127 commentedon Feb 13, 2024
abekkala commentedon Feb 15, 2024
@arielgreen added to your project board for vip-split
eVoloshchak commentedon Feb 15, 2024
@ikevin127's proposal looks good to me!
@ikevin127, when creating the PR, please also include tests from #29314 for us and the QA to test
🎀👀🎀 C+ reviewed!
55 remaining items
gedu commentedon Apr 2, 2024
Hey hey, I was OOO, today I will start looking into it
gedu commentedon Apr 2, 2024
@joekaufmanexpensify I did a first investigation, was a bit hard to reproduce it, the only way I could, it is going into the chat before the Date modification arrives. Even tho, the logic is working ok, because the user opens the chat before the message arrives, meaning that is looking at the chat before the Date modification shows up, so the green line it is showing to the last message. Will try to explain in with some steps what it is going on:
Issue 1)
So the green line is showing at the right place, because the report
lastReadTimeis not < date reportActioncreatevalueIssue 2)

What I saw, that sometimes the report
lastReadTimehasundefined, so the green line it is showing at the topSo to fix this one into the function
calculateUnreadMarkerwe should add a condition to skip the calculation of the marker when the report.lastReadTime is not setShould I do a proposal for the issue 2?
joekaufmanexpensify commentedon Apr 3, 2024
It sounds like then for issue 1, we can do nothing, right? For issue 2, do you mind clarifying how you reproduce that so I can try?
gedu commentedon Apr 3, 2024
For issue 1, yes, do nothing.
issue 2: will be doing the same steps but faster. You will see in the next video that all the messages are there already but the green line is placed at the top
request_money_undefined.mp4
gedu commentedon Apr 4, 2024
@joekaufmanexpensify could you reproduce it?
joekaufmanexpensify commentedon Apr 4, 2024
Is the bug there only because you had the two windows open enabling you to do this more quickly? And if you were doing it in one window, timing wise, it would not happen?
If so, I'm not convinced it's worth doing anything to change that. It doesn't feel super likely to be that many/anyone will be doing that.
gedu commentedon Apr 4, 2024
joekaufmanexpensify commentedon Apr 4, 2024
Got it. I'm not convinced this is worth doing anything then. Perhaps we should just close?
gedu commentedon Apr 5, 2024
Yes, we can close it, and if the future if the issue 2 start being easy to reproduce by users I can handle it
@joekaufmanexpensify
abekkala commentedon Apr 8, 2024
Tbanks for handling this one while I was ooo @joekaufmanexpensify
Closing this one based on above