Skip to content

[LOW] [Splits] [$500] Chat - Green line is not present correctly on the first unread system message #36399

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause-Internal team

Action Performed:

  1. User A request money from User B
  2. User B open chat with user A
  3. User A edit the amount, description, merchant and date
  4. User B open the detail IOU page

Expected Result:

New green line should be present above changed amount system message

Actual Result:

New green line is present above Merchant edit system message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6377848_1707818049428.Recording__2245.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0117ea985dcf52297d
  • Upwork Job ID: 1757347204057006080
  • Last Price Increase: 2024-03-22
  • Automatic offers:
    • ikevin127 | Contributor | 0

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2024
  2. melvin-bot commented on Feb 13, 2024

    @melvin-bot
  3. changed the title [-]Chat - Green line is not present correctly on the first unread system message[/-] [+][$500] Chat - Green line is not present correctly on the first unread system message[/+] on Feb 13, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 13, 2024
  5. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  6. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. ikevin127 commented on Feb 13, 2024

    @ikevin127
  8. abekkala commented on Feb 15, 2024

    @abekkala
    Contributor

    @arielgreen added to your project board for vip-split

  9. eVoloshchak commented on Feb 15, 2024

    @eVoloshchak
    Contributor

    @ikevin127's proposal looks good to me!
    @ikevin127, when creating the PR, please also include tests from #29314 for us and the QA to test

    🎀👀🎀 C+ reviewed!

  10. 55 remaining items

  11. gedu commented on Apr 2, 2024

    @gedu
    Contributor

    Hey hey, I was OOO, today I will start looking into it

  12. gedu commented on Apr 2, 2024

    @gedu
    Contributor

    @joekaufmanexpensify I did a first investigation, was a bit hard to reproduce it, the only way I could, it is going into the chat before the Date modification arrives. Even tho, the logic is working ok, because the user opens the chat before the message arrives, meaning that is looking at the chat before the Date modification shows up, so the green line it is showing to the last message. Will try to explain in with some steps what it is going on:
    Issue 1)

    User B User A
    send money request Receives it (not focus)
    Modify Description Receives it (not focus)
    Modify Merchant Receives it (not focus)
    Modify Date Focus the chat, green line is placed at Merchant message
    __ Receives the Date Modification

    So the green line is showing at the right place, because the report lastReadTime is not < date reportAction create value

    Issue 2)
    What I saw, that sometimes the report lastReadTime has undefined, so the green line it is showing at the top
    Screenshot 2024-04-02 at 16 47 09

    So to fix this one into the function calculateUnreadMarker we should add a condition to skip the calculation of the marker when the report.lastReadTime is not set

    Screenshot 2024-04-02 at 13 45 19 Screenshot 2024-04-02 at 13 45 53

    Should I do a proposal for the issue 2?

  13. joekaufmanexpensify commented on Apr 3, 2024

    @joekaufmanexpensify
    Contributor

    It sounds like then for issue 1, we can do nothing, right? For issue 2, do you mind clarifying how you reproduce that so I can try?

  14. gedu commented on Apr 3, 2024

    @gedu
    Contributor

    For issue 1, yes, do nothing.
    issue 2: will be doing the same steps but faster. You will see in the next video that all the messages are there already but the green line is placed at the top

    request_money_undefined.mp4
  15. gedu commented on Apr 4, 2024

    @gedu
    Contributor

    @joekaufmanexpensify could you reproduce it?

  16. joekaufmanexpensify commented on Apr 4, 2024

    @joekaufmanexpensify
    Contributor

    Is the bug there only because you had the two windows open enabling you to do this more quickly? And if you were doing it in one window, timing wise, it would not happen?

    If so, I'm not convinced it's worth doing anything to change that. It doesn't feel super likely to be that many/anyone will be doing that.

  17. gedu commented on Apr 4, 2024

    @gedu
    Contributor

    Is the bug there only because you had the two windows open enabling you to do this more quickly?
    I think yes, I couldn't reproduce it using the app in a normal way

  18. joekaufmanexpensify commented on Apr 4, 2024

    @joekaufmanexpensify
    Contributor

    Got it. I'm not convinced this is worth doing anything then. Perhaps we should just close?

  19. gedu commented on Apr 5, 2024

    @gedu
    Contributor

    Yes, we can close it, and if the future if the issue 2 start being easy to reproduce by users I can handle it
    @joekaufmanexpensify

  20. abekkala commented on Apr 8, 2024

    @abekkala
    Contributor

    Tbanks for handling this one while I was ooo @joekaufmanexpensify

    Closing this one based on above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions