You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-26] [HOLD FOR PAYMENT 21-02-2024] [Android] Support 'Hide sensitive notification content' Android OS setting #36413
changed the title [-][Android] Support 'Hide sensitive notification content' Android OS setting[/-][+][HOLD FOR PAYMENT 21-02-2024] [Android] Support 'Hide sensitive notification content' Android OS setting[/+]on Feb 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: Nope, it's a feature request
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Nope, it's a feature request
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: ⛔ Nope, I think this issue is not related so much on how our app work but a setting how notifications are displayed.
Activity
melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Julesssss commentedon Feb 13, 2024
There's a flag somewhere that lets us mark our app as one that shows messages/sensitive content, probably in the native Android notification classes.
dylanexpensify commentedon Feb 13, 2024
@Julesssss can this be external?
Julesssss commentedon Feb 14, 2024
Hey @dylanexpensify, oh yeah I forgot to add the label.
But this will only take 5 minutes so I'll do it myself when I have a spare moment 👍
Julesssss commentedon Feb 14, 2024
PR in review
hoangzinh commentedon Feb 15, 2024
@Julesssss @dylanexpensify could you help to assign me to this issue as a C+? I reviewed the PR. Thanks
[-][Android] Support 'Hide sensitive notification content' Android OS setting[/-][+][HOLD FOR PAYMENT 21-02-2024] [Android] Support 'Hide sensitive notification content' Android OS setting[/+]5 remaining items
melvin-bot commentedon Feb 19, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 19, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dylanexpensify commentedon Feb 21, 2024
payment coming up!
melvin-bot commentedon Feb 26, 2024
Payment Summary
Upwork Job
BugZero Checklist (@dylanexpensify)
hoangzinh commentedon Feb 26, 2024
BugZero Checklist:
dylanexpensify commentedon Feb 26, 2024
Payment summary:
Please request!
hoangzinh commentedon Feb 26, 2024
@dylanexpensify could you please send the upwork offer? Thanks
dylanexpensify commentedon Feb 28, 2024
Doing today!
dylanexpensify commentedon Feb 28, 2024
sent @hoangzinh!
hoangzinh commentedon Feb 28, 2024
Accepted. Thanks @dylanexpensify