Skip to content

[HOLD for payment 2024-02-26] [HOLD FOR PAYMENT 21-02-2024] [Android] Support 'Hide sensitive notification content' Android OS setting #36413

Closed

Description

@Julesssss

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: me

Action Performed:

  • Disable the Show 'sensitive notifications' preference under Settings > Notifications
  • Lock the device
  • Receive messages from Expensify and other communication apps

Expected Result:

  • You shouldn't be able to read text and see the senders photo

Actual Result:

  • You can read text and see the senders photo

Screenshot_20240213_134649
Screenshot_20240213_134054

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2024
  2. self-assigned this
    on Feb 13, 2024
  3. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. Julesssss commented on Feb 13, 2024

    @Julesssss
    ContributorAuthor

    There's a flag somewhere that lets us mark our app as one that shows messages/sensitive content, probably in the native Android notification classes.

  5. dylanexpensify commented on Feb 13, 2024

    @dylanexpensify
    Contributor

    @Julesssss can this be external?

  6. Julesssss commented on Feb 14, 2024

    @Julesssss
    ContributorAuthor

    Hey @dylanexpensify, oh yeah I forgot to add the label.

    But this will only take 5 minutes so I'll do it myself when I have a spare moment 👍

  7. Julesssss commented on Feb 14, 2024

    @Julesssss
    ContributorAuthor

    PR in review

  8. hoangzinh commented on Feb 15, 2024

    @hoangzinh
    Contributor

    @Julesssss @dylanexpensify could you help to assign me to this issue as a C+? I reviewed the PR. Thanks

  9. changed the title [-][Android] Support 'Hide sensitive notification content' Android OS setting[/-] [+][HOLD FOR PAYMENT 21-02-2024] [Android] Support 'Hide sensitive notification content' Android OS setting[/+] on Feb 15, 2024
  10. 5 remaining items

  11. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
    • [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hoangzinh] Determine if we should create a regression test for this bug.
    • [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. dylanexpensify commented on Feb 21, 2024

    @dylanexpensify
    Contributor

    payment coming up!

  15. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@dylanexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. hoangzinh commented on Feb 26, 2024

    @hoangzinh
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: Nope, it's a feature request
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Nope, it's a feature request
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: ⛔ Nope, I think this issue is not related so much on how our app work but a setting how notifications are displayed.
  17. dylanexpensify commented on Feb 26, 2024

    @dylanexpensify
    Contributor

    Payment summary:

    Please request!

  18. hoangzinh commented on Feb 26, 2024

    @hoangzinh
    Contributor

    @dylanexpensify could you please send the upwork offer? Thanks

  19. dylanexpensify commented on Feb 28, 2024

    @dylanexpensify
    Contributor

    Doing today!

  20. dylanexpensify commented on Feb 28, 2024

    @dylanexpensify
    Contributor
  21. hoangzinh commented on Feb 28, 2024

    @hoangzinh
    Contributor

    Accepted. Thanks @dylanexpensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions