You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-07] HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page #36430
Version Number: v1.4.40-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Anonymous user Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@muttmuure Slack conversation:
I did some digging and was able to reproduce and find a workaround locally, but not sure if the solution is good or not. I'm discussing this in this thread.
changed the title [-]HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page [/-][+][HOLD for payment 2024-03-07] HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page [/+]on Feb 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@youssef-lr] The PR that introduced the bug has been identified. Link to the PR: No offending PR, this is not a regression.
[@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@youssef-lr] Determine if we should create a regression test for this bug.
[@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.: I don't think a regression test is needed here.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.bfitzexpensify commentedon Feb 16, 2024
Added to a project and assigned a priority - waiting for a volunteer
bfitzexpensify commentedon Feb 19, 2024
Same status
youssef-lr commentedon Feb 19, 2024
I did some digging and was able to reproduce and find a workaround locally, but not sure if the solution is good or not. I'm discussing this in this thread.
youssef-lr commentedon Feb 20, 2024
Resumed the discussion in the thread.
youssef-lr commentedon Feb 22, 2024
Making a PR.
youssef-lr commentedon Feb 23, 2024
We're still discussing the PR.
3 remaining items
marcaaron commentedon Feb 27, 2024
LGTM (though, I am not sure I had much more context than anyone else)
youssef-lr commentedon Feb 27, 2024
PR is merged.
youssef-lr commentedon Feb 29, 2024
Tested this in staging, working good. @muttmuure please give it another test so we can confirm it's fixed: https://staging.new.expensify.com/r/6776919265133947
[-]HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page [/-][+][HOLD for payment 2024-03-07] HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page [/+]melvin-bot commentedon Feb 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-07. 🎊
melvin-bot commentedon Feb 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: