Skip to content

[HOLD for payment 2024-03-07] HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page  #36430

Closed

Description

@muttmuure

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.40-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): Anonymous user
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @muttmuure
Slack conversation:

Action Performed:

  1. Open Incognito browser
  2. Navigate to https://new.expensify.com/r/6776919265133947
  3. Open a thread within 5 seconds of page loading

Expected Result:

Describe what you think should've happened

The thread loads

Actual Result:

Describe what actually happened

You see an "It's not here" message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Navigate.to.thread.immediately.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2024
  2. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. bfitzexpensify commented on Feb 16, 2024

    @bfitzexpensify
    Contributor

    Added to a project and assigned a priority - waiting for a volunteer

  4. bfitzexpensify commented on Feb 19, 2024

    @bfitzexpensify
    Contributor

    Same status

  5. self-assigned this
    on Feb 19, 2024
  6. youssef-lr commented on Feb 19, 2024

    @youssef-lr
    Contributor

    I did some digging and was able to reproduce and find a workaround locally, but not sure if the solution is good or not. I'm discussing this in this thread.

  7. youssef-lr commented on Feb 20, 2024

    @youssef-lr
    Contributor

    Resumed the discussion in the thread.

  8. youssef-lr commented on Feb 22, 2024

    @youssef-lr
    Contributor

    Making a PR.

  9. youssef-lr commented on Feb 23, 2024

    @youssef-lr
    Contributor

    We're still discussing the PR.

  10. 3 remaining items

  11. marcaaron commented on Feb 27, 2024

    @marcaaron
    Contributor

    LGTM (though, I am not sure I had much more context than anyone else)

  12. youssef-lr commented on Feb 27, 2024

    @youssef-lr
    Contributor

    PR is merged.

  13. youssef-lr commented on Feb 29, 2024

    @youssef-lr
    Contributor

    Tested this in staging, working good. @muttmuure please give it another test so we can confirm it's fixed: https://staging.new.expensify.com/r/6776919265133947

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 29, 2024
  15. changed the title [-]HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page [/-] [+][HOLD for payment 2024-03-07] HIGH: Navigating to a thread in a public room immediately as an anonymous user shows "it's not here" page [/+] on Feb 29, 2024
  16. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-07. 🎊

  18. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR: No offending PR, this is not a regression.
    • [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@youssef-lr] Determine if we should create a regression test for this bug.
    • [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.: I don't think a regression test is needed here.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions