Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707848268463619
Action Performed:
- Go to OldDot staging.expensify.com and open or create a Collect policy
- Make tags required for the policy
- Go to Settings > [Workspace] > Tags
- Enable "People must tag expenses"
- Add a tag
- Set violations for category as to be required
- Go to the policy page
- In the JS console with the policy open do:
p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save();
- Invite a user to the policy as employee
- As an employee sign in to the NewDot, create a expense report without category and tag set
- Open the report as approver logged in to NewDot
Expected Result:
Error message for violations are shown
Actual Result:
Not seeing violations as approver
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence

Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ebca0f5b1a041068
- Upwork Job ID: 1757526242287419392
- Last Price Increase: 2024-02-22
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Violations are not shown as approver[/-][+][$500] Violations are not shown as approver[/+]melvin-bot commentedon Feb 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ebca0f5b1a041068
melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)brandonhenry commentedon Feb 15, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Approvers are not seeing the expected error messages for violation of expense report policies, specifically when category and tag settings are required but not set by the employee on the report.
What is the root cause of that problem?
The root cause may involve the policy enforcement logic within the approver's view. It appears the validation checks that trigger error messages for missing categories or tags are not executing correctly, or the UI is not displaying the results of these checks as it should.
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
bfitzexpensify commentedon Feb 16, 2024
@cead22 is this something you're planning on working on yourself, or is this something that contributors can tackle?
51 remaining items
melvin-bot commentedon Mar 18, 2024
@cead22, @parasharrajat, @bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...
[-][$1000] Violations are not shown as approver[/-][+][Violations][$1000] Violations are not shown as approver[/+][-][Violations][$1000] Violations are not shown as approver[/-][+][Violations] [$1000] Violations are not shown as approver[/+]JmillsExpensify commentedon Mar 26, 2024
Nice! With both of those merged and on production, can we close this issue now?
cead22 commentedon Mar 26, 2024
Yup!