You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Task – Assignee with the custom name is shown as email in a task name #36443
Version Number: v1.4.41-2 Reproducible in staging?: Y Reproducible in production?: Y Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation:
changed the title [-]Task – Assignee with the custom name is shown as email in a task name[/-][+][$500] Task – Assignee with the custom name is shown as email in a task name[/+]on Feb 13, 2024
📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed @jjcoffee:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes - if one doesn't exist already
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Create a task with any title
Assign a user with a display name set
Share somewhere
Navigate to the chat where the task was shared
Verify the assignment in the task preview shows the user's custom name
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Feb 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01a831cc646a8c8645
[-]Task – Assignee with the custom name is shown as email in a task name[/-][+][$500] Task – Assignee with the custom name is shown as email in a task name[/+]melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.izarutskaya commentedon Feb 13, 2024
We think that this bug might be related to #vip-vsb
CC @quinthar
eucool commentedon Feb 13, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Assignee with the custom name is shown as email in a task name
What is the root cause of that problem?
We display the email instead of the user name:
App/src/components/ReportActionItem/TaskPreview.tsx
Line 77 in d50d603
What changes do you think we should make in order to solve the problem?
Get personal details:
change the email to name assignment:
What alternative solutions did you explore? (Optional)
N/A
jeremy-croff commentedon Feb 13, 2024
Regression?
8c802ed
jjcoffee commentedon Feb 14, 2024
Thanks @jeremy-croff, that does look like a possible regression. Checking with the PR author.
jjcoffee commentedon Feb 15, 2024
Looks like it's actually a regression from #35462 as the order was changed here. @mollfpr Can you check?
14 remaining items
melvin-bot commentedon Feb 21, 2024
📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
paultsimura commentedon Feb 21, 2024
Thanks. The PR is ready for review: #36998
adelekennedy commentedon Mar 11, 2024
SORRY - late payment from me
Payouts due:
Contributor: $500 @paultsimura (Upwork)
Contributor+: $500 @jjcoffee (Upwork)
Upwork job is here.
adelekennedy commentedon Mar 11, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed @jjcoffee:
jjcoffee commentedon Mar 12, 2024
Regression Test Proposal
Do we agree 👍 or 👎
adelekennedy commentedon Mar 12, 2024
makes sense to me - I'll wait if @techievivek has any more input
melvin-bot commentedon Apr 5, 2024
This issue has not been updated in over 15 days. @paultsimura, @jjcoffee, @techievivek, @adelekennedy eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
jjcoffee commentedon Apr 8, 2024
@adelekennedy I think this can be closed?
techievivek commentedon Apr 8, 2024
Sorry I missed the ping, I have created a GH to add the regression test here: https://github.com/Expensify/Expensify/issues/385997, I am guessing payment is done here so we can close it out.