Skip to content

[$500] Task – Assignee with the custom name is shown as email in a task name #36443

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login
  3. Navigate to a Group Chat
  4. Click on the + in the compose box and select "Assign task"
  5. Enter a a Title
  6. Assign a user with the custom name
  7. Create the task

Expected Result:

The assignee with the custom name is displayed in the assignee field with custom name

Actual Result:

Assignee with the custom name is shown as email in a task name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6378618_1707856950328.Assignee_with_the_custom_name_is_shown_as_email_in_a_task_name.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a831cc646a8c8645
  • Upwork Job ID: 1757532483996348416
  • Last Price Increase: 2024-02-20
  • Automatic offers:
    • jjcoffee | Reviewer | 0
    • paultsimura | Contributor | 0

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2024
  2. melvin-bot commented on Feb 13, 2024

    @melvin-bot
  3. changed the title [-]Task – Assignee with the custom name is shown as email in a task name[/-] [+][$500] Task – Assignee with the custom name is shown as email in a task name[/+] on Feb 13, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 13, 2024
  5. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  6. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. izarutskaya commented on Feb 13, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #vip-vsb
    CC @quinthar

  8. eucool commented on Feb 13, 2024

    @eucool
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Assignee with the custom name is shown as email in a task name

    What is the root cause of that problem?

    We display the email instead of the user name:

    taskAssigneeAccountID !== 0 ? `<comment><mention-user accountid="${taskAssigneeAccountID}"></mention-user> ${taskTitle}</comment>` : `<comment>${taskTitle}</comment>`;

    What changes do you think we should make in order to solve the problem?

    Get personal details:

        const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
        const assigneeLogin = personalDetails[taskAssigneeAccountID]?.login ?? '';
        const assigneeDisplayName = personalDetails[taskAssigneeAccountID]?.displayName ?? '';
        const taskAssignee = assigneeDisplayName || LocalePhoneNumber.formatPhoneNumber(assigneeLogin);

    change the email to name assignment:

    <mention-user accountid="${taskAssigneeAccountID}">@${taskAssignee}</mention-user>

    What alternative solutions did you explore? (Optional)

    N/A

  9. jeremy-croff commented on Feb 13, 2024

    @jeremy-croff
    Contributor

    Regression?
    8c802ed

  10. jjcoffee commented on Feb 14, 2024

    @jjcoffee
    Contributor

    Thanks @jeremy-croff, that does look like a possible regression. Checking with the PR author.

  11. jjcoffee commented on Feb 15, 2024

    @jjcoffee
    Contributor

    Looks like it's actually a regression from #35462 as the order was changed here. @mollfpr Can you check?

  12. 14 remaining items

  13. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  14. paultsimura commented on Feb 21, 2024

    @paultsimura
    Contributor

    Thanks. The PR is ready for review: #36998

  15. adelekennedy commented on Mar 11, 2024

    @adelekennedy
    Contributor

    SORRY - late payment from me

    Payouts due:

    Contributor: $500 @paultsimura (Upwork)
    Contributor+: $500 @jjcoffee (Upwork)

    Upwork job is here.

  16. adelekennedy commented on Mar 11, 2024

    @adelekennedy
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed @jjcoffee:

    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
  17. jjcoffee commented on Mar 12, 2024

    @jjcoffee
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: [TS migration] Migrate HTMLRenderers components #35462
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/35462/files#r1521218238
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes - if one doesn't exist already
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Create a task with any title
    2. Assign a user with a display name set
    3. Share somewhere
    4. Navigate to the chat where the task was shared
    5. Verify the assignment in the task preview shows the user's custom name

    Do we agree 👍 or 👎

  18. adelekennedy commented on Mar 12, 2024

    @adelekennedy
    Contributor

    makes sense to me - I'll wait if @techievivek has any more input

  19. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @paultsimura, @jjcoffee, @techievivek, @adelekennedy eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  20. jjcoffee commented on Apr 8, 2024

    @jjcoffee
    Contributor

    @adelekennedy I think this can be closed?

  21. techievivek commented on Apr 8, 2024

    @techievivek
    Contributor

    Sorry I missed the ping, I have created a GH to add the regression test here: https://github.com/Expensify/Expensify/issues/385997, I am guessing payment is done here so we can close it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions