Repository navigation
[$500] Bank account - Form is auto-submitted after disabling internet and killing app #36456
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.41-2
Reproducible in staging?: y
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Go to Workspace > Bank account.
- Select Connect online with Plaid and go through the add BA flow until you reach the SSN page of Personal info.
- Disable internet connection.
- Enter "33".
- Kill the app.
- Open the app again.
- Enter the address info.
- Verify that the incorrect info for SSN was submitted.
Expected Result:
The form for SSN should not auto-submit and an error for incorrect data entered should appear.
Actual Result:
The form for SSN is auto-submitted with the incorrect data.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6378802_1707871927871.Bhbh7855_1_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01126719388570e4b1
- Upwork Job ID: 1757588631042637824
- Last Price Increase: 2024-02-14
- Automatic offers:
- akinwale | Contributor | 0
Activity
[-]Bank account - Form is auto-submitted after disabling internet and killing app[/-][+][$500] Bank account - Form is auto-submitted after disabling internet and killing app[/+]melvin-bot commentedon Feb 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01126719388570e4b1
melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
2 remaining items
melvin-bot commentedon Feb 14, 2024
📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
mountiny commentedon Feb 14, 2024
@shubham1206agra @MrMuzyk @barttom This one seems like something we should look at but very small edge case.
MrMuzyk commentedon Feb 14, 2024
@mountiny Assign me and I'll have a look
MrMuzyk commentedon Feb 14, 2024
This will happen more often than described. You could alternatively just fill in 2 digits, close the process and open it again (without disconnecting internet). All values are being saved in draft immediately after being entered. When process is opened again there is a check to see which values has been already filled in (its only check against empty string) and opens next substep. However when you try to actually submit it (send it to BE) you do get an error explaining what's wrong.
Potential improvement would be to also validate existing draft values before navigating user to substep. I'm looking into it.
This applies to all inputs in the VBBA flow. Not only to this particular one showed in issue description
mountiny commentedon Feb 14, 2024
@MrMuzyk thanks for clarifications.
Frankly I think its fine since we get the error from the backend. I think changing the way validation happens is a change which should be discussed more rather than a quick fix.
In that case I would be fine with closing this
nkuoch commentedon Feb 14, 2024
I agree, let's close it and focus on real problems.
mountiny commentedon Feb 14, 2024
Thanks