Skip to content

IOU - Billable no longer valid violation is not displayed under the field #36481

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4312606
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: as an employee of a workspace, create an expense with Billable option toggled on.

  1. As the admin of the workspace on OD, set "Re-bill expenses to clients" to Disabled.
  2. As the employee on ND, go to the details page of the created expense.

Expected Result:

Billable no longer valid violation should be displayed under the field.

Actual Result:

Billable no longer valid violation is displayed on the right side and the toggle button is moved to the middle.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Activity

  1. github-actions commented on Feb 14, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 14, 2024

    @melvin-bot

    Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Feb 14, 2024

    @kbecciv
    Author

    We think that this bug might be related #wave6-collect-submitters
    CC @greg-schroeder

  4. neonbhai commented on Feb 14, 2024

    @neonbhai
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Billable no longer valid violation is not displayed under the field

    What is the root cause of that problem?

    We are displaying the violation incorrectly. It should be after this View

    What changes do you think we should make in order to solve the problem?

    We should move ViolationMessage after this View

  5. pecanoro commented on Feb 14, 2024

    @pecanoro
    Contributor

    @kbecciv On production, does it show under the button or it doesn't show at all?

  6. amyevans commented on Feb 14, 2024

    @amyevans
    Contributor

    @cead22 @trevor-coleman is this an expected change?

  7. trevor-coleman commented on Feb 14, 2024

    @trevor-coleman
    Contributor

    No it should be underneath. Moving it outside that view should fix it.

  8. amyevans commented on Feb 14, 2024

    @amyevans
    Contributor

    @trevor-coleman Got it, thanks! could you open a PR to fix please?

  9. neonbhai commented on Feb 14, 2024

    @neonbhai
    Contributor

    Would love to raise the PR if needed!

  10. pecanoro commented on Feb 14, 2024

    @pecanoro
    Contributor

    I need to check if this a regression for a PR or it was introduced by a new feature

  11. amyevans commented on Feb 14, 2024

    @amyevans
    Contributor

    @pecanoro it's from #34303

  12. pecanoro commented on Feb 14, 2024

    @pecanoro
    Contributor

    @amyevans Thank you! So it was a regression from that PR. As she mentioned, @trevor-coleman can you fix it since it was your PR or should we find a volunteer?

  13. trevor-coleman commented on Feb 14, 2024

    @trevor-coleman
    Contributor

    I've got a fix done just making a PR now--the screenshots will take some time.

  14. pecanoro commented on Feb 14, 2024

    @pecanoro
    Contributor

    @trevor-coleman Cool, thank you so much!

  15. trevor-coleman commented on Feb 14, 2024

    @trevor-coleman
    Contributor

    Because of the difference between web and native, just moving the messages below wasn't working, so I ended up leaving the violation messages where they are adding override props to the container and text styles that let me put them where they needed to be.

    Android:
    CleanShot 2024-02-14 at 13 24 30@2x

    Web:
    CleanShot 2024-02-14 at 13 24 51@2x

  16. trevor-coleman commented on Feb 14, 2024

    @trevor-coleman
    Contributor

    PR is up: #36533

  17. pecanoro commented on Feb 14, 2024

    @pecanoro
    Contributor

    Either way, since it's just visual and it does not break things completely, I am going to remove the deploy blocker and we can merge it tomorrow. @cead22 Do you agree?

  18. aimane-chnaif commented on Feb 14, 2024

    @aimane-chnaif
    Contributor

    violations is still in beta so not deploy blocker

  19. pecanoro commented on Feb 29, 2024

    @pecanoro
    Contributor

    Issue for payment created, gonna closed this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions