You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
IOU - Billable no longer valid violation is not displayed under the field #36481
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@amyevans Thank you! So it was a regression from that PR. As she mentioned, @trevor-coleman can you fix it since it was your PR or should we find a volunteer?
Because of the difference between web and native, just moving the messages below wasn't working, so I ended up leaving the violation messages where they are adding override props to the container and text styles that let me put them where they needed to be.
Either way, since it's just visual and it does not break things completely, I am going to remove the deploy blocker and we can merge it tomorrow. @cead22 Do you agree?
Activity
github-actions commentedon Feb 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to @pecanoro (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Feb 14, 2024
We think that this bug might be related #wave6-collect-submitters
CC @greg-schroeder
neonbhai commentedon Feb 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Billable no longer valid violation is not displayed under the field
What is the root cause of that problem?
We are displaying the violation incorrectly. It should be after this View
What changes do you think we should make in order to solve the problem?
We should move ViolationMessage after this View
pecanoro commentedon Feb 14, 2024
@kbecciv On production, does it show under the button or it doesn't show at all?
amyevans commentedon Feb 14, 2024
@cead22 @trevor-coleman is this an expected change?
trevor-coleman commentedon Feb 14, 2024
No it should be underneath. Moving it outside that view should fix it.
amyevans commentedon Feb 14, 2024
@trevor-coleman Got it, thanks! could you open a PR to fix please?
neonbhai commentedon Feb 14, 2024
Would love to raise the PR if needed!
pecanoro commentedon Feb 14, 2024
I need to check if this a regression for a PR or it was introduced by a new feature
amyevans commentedon Feb 14, 2024
@pecanoro it's from #34303
pecanoro commentedon Feb 14, 2024
@amyevans Thank you! So it was a regression from that PR. As she mentioned, @trevor-coleman can you fix it since it was your PR or should we find a volunteer?
trevor-coleman commentedon Feb 14, 2024
I've got a fix done just making a PR now--the screenshots will take some time.
pecanoro commentedon Feb 14, 2024
@trevor-coleman Cool, thank you so much!
trevor-coleman commentedon Feb 14, 2024
Because of the difference between web and native, just moving the messages below wasn't working, so I ended up leaving the violation messages where they are adding override props to the container and text styles that let me put them where they needed to be.
Android:

Web:

trevor-coleman commentedon Feb 14, 2024
PR is up: #36533
pecanoro commentedon Feb 14, 2024
Either way, since it's just visual and it does not break things completely, I am going to remove the deploy blocker and we can merge it tomorrow. @cead22 Do you agree?
aimane-chnaif commentedon Feb 14, 2024
violations is still in beta so not deploy blocker
pecanoro commentedon Feb 29, 2024
Issue for payment created, gonna closed this one