You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-07] [$500] Web - IOU - I can't navigate using the "Tab" key #36513
Version Number: 1.4.41.1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Open FAB > Request money
Select manual, enter a value and click "Next"
Select a workspace chat
Press the "Tab" key
Expected Result:
I should be able to use it
Actual Result:
I can't navigate using the "Tab" key. It works in task request flow
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
📣 @damadoko! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
changed the title [-][$500] Web - IOU - I can't navigate using the "Tab" key[/-][+][HOLD for payment 2024-03-07] [$500] Web - IOU - I can't navigate using the "Tab" key[/+]on Feb 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
[@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cubuspl42] Determine if we should create a regression test for this bug.
[@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Heads up, I will be offline until Tuesday, March 5, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the Open Source Slack Room-- thanks!
Activity
[-]Web - IOU - I can't navigate using the "Tab" key[/-][+][$500] Web - IOU - I can't navigate using the "Tab" key[/+]melvin-bot commentedon Feb 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0144e80c4837a63c84
melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (
External)melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Feb 14, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
bernhardoj commentedon Feb 15, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can't navigate using the TAB key on the money request page.
What is the root cause of that problem?
In #35154, we intentionally disable the TAB to "fix" #26326.
App/src/pages/iou/request/IOURequestStartPage.js
Lines 91 to 102 in 6914b13
But this affected all money request page, including participant and confirmation page.
What changes do you think we should make in order to solve the problem?
We should unregister the tab listener when the screen is out focus. We can use
useFocusEffectto achieve it.What alternative solutions did you explore? (Optional)
This isn't the best solution, but just in case. We can store the navigation focus state to a ref and return early if the page is not focused anymore.
jakub-trzebiatowski commentedon Feb 15, 2024
@bernhardoj
Just to confirm, does your solution keep #26326 fixed?
damadoko commentedon Feb 15, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can not navigate by tab key in request money page.
What is the root cause of that problem?
Since #35154 to fix #26326
App/src/pages/iou/request/IOURequestStartPage.js
Lines 91 to 102 in 6914b13
This change disable all tab actions in request money page (which wrapped by
IOURequestStartPagecomponent)What changes do you think we should make in order to solve the problem?
visibility: hiddento not-activeTopTab.Screen, all focusable child of that element will not tab(able) anymore.What alternative solutions did you explore? (Optional)
Above solution need to change all
TopTab.Screenimplementation. I think about more generic solution which make changes inOnyxTabNavigator's children:melvin-bot commentedon Feb 15, 2024
📣 @damadoko! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
18 remaining items
bernhardoj commentedon Feb 20, 2024
PR is ready
cc: @cubuspl42
alexpensify commentedon Feb 28, 2024
Update: The PR is waiting for @mountiny's review but I'll try to find a replacement. I think you are offline.
[-][$500] Web - IOU - I can't navigate using the "Tab" key[/-][+][HOLD for payment 2024-03-07] [$500] Web - IOU - I can't navigate using the "Tab" key[/+]melvin-bot commentedon Feb 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
alexpensify commentedon Mar 1, 2024
Awesome, looks like automation kicked in here.
Heads up, I will be offline until Tuesday, March 5, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the Open Source Slack Room-- thanks!
alexpensify commentedon Mar 8, 2024
Alright, I've completed the payment summary here:
#36513 (comment)
For this Upwork Job:
https://www.upwork.com/jobs/~0144e80c4837a63c84
Closing - Everyone has been paid via Upwork.