Repository navigation
[Hold for payment - 2024-03-07] MEDIUM: Custom message sound not consistent on mobile #36579
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.42-0
Reproducible in staging?: Yes
Action Performed:
- Send a message to a user signed in on mobile in three different app states:
- App Killed
- App Open
- App in background
Expected Result:
- App Killed: Custom sound
- App Open: Custom sound
- App in background: Custom sound
Actual Result:
- App Killed: Default notification sound
- App Open: Custom sound
- App in background: Default notification sound
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Feb 15, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kirillzyusko commentedon Feb 15, 2024
Thanks for bringing this up! As I have written that feature let me take some time trying to reproduce. I'll let you know if I found anything 👀
Julesssss commentedon Feb 15, 2024
I can also help with backend changes. As you mentioned we may need to start sending a reportType variable -- though I also think we don't send IOU notifications currently
Julesssss commentedon Feb 19, 2024
@kirillzyusko and I discussed. We can drop the message received sound on mobile apps as this is being handled by the OS push notification itself.
13 remaining items
Julesssss commentedon Feb 29, 2024
Awaiting C+ payment
[-]MEDIUM: Custom message sound not consistent on mobile[/-][+][Hold for payment - 2024-03-07] MEDIUM: Custom message sound not consistent on mobile[/+]abdulrahuman5196 commentedon Mar 5, 2024
Not a regression. Update to existing implementation
Yes.
Julesssss commentedon Mar 5, 2024
We're still making changes to the push notification logic so this test will soon be outdated. We'll create one seperately once the changes are complete.
CortneyOfstad commentedon Mar 11, 2024
Sorry, was OoO last week — handling the payment now!
CortneyOfstad commentedon Mar 11, 2024
@Julesssss in regards to the comment here, is a regression test needed here if there will be separate tests created after the logic is adjusted? Just trying to confirm — thank you!
CortneyOfstad commentedon Mar 11, 2024
@abdulrahuman5196 I sent you a job offer here — https://www.upwork.com/jobs/~01d297cc64a730c705
Not sure why the job did not post originally, but please let me know once you accept and I'll get that paid ASAP. Thanks!
abdulrahuman5196 commentedon Mar 11, 2024
@CortneyOfstad accepted the offer. Thank you
CortneyOfstad commentedon Mar 11, 2024
Paid!
Payment Summary
@abdulrahuman5196 — paid $500 via Upwork!
Julesssss commentedon Mar 12, 2024
Hi @CortneyOfstad, no test needed here
CortneyOfstad commentedon Mar 12, 2024
Perfect! This can be closed — thanks everyone!