[HOLD for payment 2024-03-14] [$500] Workspace - System message for workspace description edit with mark down is not gray

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Navigate to staging.new.expensify.com
Create a new workspace.
Go to workspace profile.
Click Workspace description.
Save a description without mark down.
Click Workspace description.
Save another description with mark down.
Go to #admin room.

Expected Result:

The system message for workspace description edit should appear gray, regardless of the usage of mark down in the description.

Actual Result:

The system message for workspace description edit is not grayed out when mark down is involved.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6380766_1708008538695.bandicam_2024-02-15_16-00-04-569.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01435fd857fbcc98a7
Upwork Job ID: 1759631118974234624
Last Price Increase: 2024-02-19
Automatic offers:

hoangzinh | Contributor | 0

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@puneetlath

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

This is useful to fix, but also doesn't feel like a blocker since everything seems to be working fine (just not a grayed out system message)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace description system message is not grayed out when the description is a markdown.

What is the root cause of that problem?

Currently, we check the action name and apply the gray color.

App/src/pages/home/report/ReportActionItem.js

Lines 482 to 494 in 9843f66

    
           style={[ 
        
               _.contains( 
        
                   [ 
        
                       ..._.values(CONST.REPORT.ACTIONS.TYPE.POLICYCHANGELOG), 
        
                       CONST.REPORT.ACTIONS.TYPE.IOU, 
        
                       CONST.REPORT.ACTIONS.TYPE.APPROVED, 
        
                       CONST.REPORT.ACTIONS.TYPE.MOVED, 
        
                   ], 
        
                   props.action.actionName, 
        
               ) 
        
                   ? styles.colorMuted 
        
                   : undefined, 
        
           ]}

This works perfectly for a plain text, but not for markdown. When the description is a markdown, it will be rendered as HTML,

App/src/pages/home/report/comment/TextCommentFragment.tsx

Lines 53 to 65 in 9843f66

    
           if (!differByLineBreaksOnly) { 
        
               const editedTag = fragment.isEdited ? `<edited ${styleAsDeleted ? 'deleted' : ''}></edited>` : ''; 
        
               const htmlContent = styleAsDeleted ? `<del>${html}</del>` : html; 
        
               const htmlWithTag = editedTag ? `${htmlContent}${editedTag}` : htmlContent; 
        
               return ( 
        
                   <RenderCommentHTML 
        
                       source={source} 
        
                       html={htmlWithTag} 
        
                   /> 
        
               ); 
        
           }

and the style we pass won't work.

What changes do you think we should make in order to solve the problem?

We can follow the same pattern as styleAsDeleted props. Instead of passing the colorMuted style, we can have a new props called, styleAsMuted with the same condition as below

App/src/pages/home/report/ReportActionItem.js

Lines 482 to 491 in 9843f66

    
           style={[ 
        
               _.contains( 
        
                   [ 
        
                       ..._.values(CONST.REPORT.ACTIONS.TYPE.POLICYCHANGELOG), 
        
                       CONST.REPORT.ACTIONS.TYPE.IOU, 
        
                       CONST.REPORT.ACTIONS.TYPE.APPROVED, 
        
                       CONST.REPORT.ACTIONS.TYPE.MOVED, 
        
                   ], 
        
                   props.action.actionName, 
        
               )

and wrap the HTML with <muted-text> tag to apply the gray text color.

let htmlWithTag = editedTag ? `${htmlContent}${editedTag}` : htmlContent;
if (styleAsMuted) {
    htmlWithTag = `<muted-text>${htmlWithTag}<muted-text>`;
}

Then, for the plain text, we will apply the style if styleAsMuted is true similar to styleAsDeleted to every text that needs it.

App/src/pages/home/report/comment/TextCommentFragment.tsx

Line 81 in 9843f66

styleAsDeleted ? styles.offlineFeedback.deleted : undefined,

Or we can just leave the current style we have to reduce the changes and regression risk. Please let me know which way we should go.

@puneetlath

@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@bernhardoj

As this was deploy blocker, there should be offending PR.
@bernhardoj you know?

Making external.

@hoangzinh

PR is ready

cc: @hoangzinh

FYI, I haven't got the auto offer yet

cc: @puneetlath

Hm, weird that it didn't work sending you the auto-offer. If it doesn't do it, I'll send you one manually when it's time to pay.

Reviewing label has been removed, please complete the "BugZero Checklist".

@hoangzinh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix workspace system message when contains markdown isn't grayed out #37124

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment automatic offer (Contributor)
@bernhardoj requires payment (Needs manual offer from BZ)

@bernhardoj

Sent you an offer @bernhardoj: https://www.upwork.com/nx/wm/offer/101362453

All paid. Thanks y'all!

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-14] [$500] Workspace - System message for workspace description edit with mark down is not gray #36598

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	style={[
	_.contains(
	[
	..._.values(CONST.REPORT.ACTIONS.TYPE.POLICYCHANGELOG),
	CONST.REPORT.ACTIONS.TYPE.IOU,
	CONST.REPORT.ACTIONS.TYPE.APPROVED,
	CONST.REPORT.ACTIONS.TYPE.MOVED,
	],
	props.action.actionName,
	)
	? styles.colorMuted
	: undefined,
	]}

	if (!differByLineBreaksOnly) {
	const editedTag = fragment.isEdited ? `<edited ${styleAsDeleted ? 'deleted' : ''}></edited>` : '';
	const htmlContent = styleAsDeleted ? `<del>${html}</del>` : html;

	const htmlWithTag = editedTag ? `${htmlContent}${editedTag}` : htmlContent;

	return (
	<RenderCommentHTML
	source={source}
	html={htmlWithTag}
	/>
	);
	}

[HOLD for payment 2024-03-14] [$500] Workspace - System message for workspace description edit with mark down is not gray #36598

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Feb 15, 2024

melvin-bot commented on Feb 15, 2024

Beamanator commented on Feb 15, 2024

bernhardoj commented on Feb 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Feb 19, 2024

situchan commented on Feb 19, 2024

puneetlath commented on Feb 19, 2024

23 remaining items

bernhardoj commented on Feb 23, 2024

puneetlath commented on Feb 23, 2024

melvin-bot commented on Mar 7, 2024

melvin-bot commented on Mar 7, 2024

puneetlath commented on Mar 13, 2024

puneetlath commented on Mar 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions