Skip to content

[HOLD for payment 2024-07-23] [CRITICAL] [P2P] Refactor the wallet enablement flow to be step by step and conform with our new design system #36648

Closed

Description

@anmurali

Problem:
The existing wallet enablement flow UI does not comply with our new brand design system, particularly our philosophy to take a stey by step approach to getting user input. It also doesn't give the user a sense of progression or context for remaining steps, which could cause drop off.

Solution:
Let's refactor the Ui to ask for the info step by step instead of all at once. Let's add a progress bar at the top for the various sections:

Starting point, no change
image

Current Add bank account step, which loads a blank modal and automatically jumps to Plaid flow. Although the only choice here at the moment, it is cleaner to just show this step and allow the user to explicitly click on Connect via Plaid
image

Current Additional Details step, which is shown as one form, with all these details. We will refactor it to ask for the details step by step here
image

Current Verify Identity step, which presents some legalese links and then moves into the Onfido SDK flow. But the Onfido SDK flow begins with disclosures that the user needs to accept, so we don't need to show this legalese twice. We will therefore change the copy at the start of this step as well.
image

The Onfido SDK flow cannot be further customized to match our branding but, can we try to add the progress bar we're using here at the top of that entire flow, if possible?

Current Terms and fees step, which is shown as one long blob, with all these details. We will refactor it to show it step by step here
image

  • The first of these screens should be scrollable and the Next button should be inactive till they get to the end and then turn active. If they try to click on it when inactive, let's present an error message to scroll to the end and review all of it.

Finished step, no change
image

Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. shawnborton commented on Feb 16, 2024

    @shawnborton
    Contributor

    For the start of the Onfido flow, I guess we should just mirror what we currently have in product (note this whole flow got a face lift recently!) where we basically just have one screen as a primer, then we kick off the Onfido flow?
    CleanShot 2024-02-16 at 08 41 39@2x

  2. shawnborton commented on Feb 16, 2024

    @shawnborton
    Contributor

    Also just cc'ing @mountiny (sorry for all the tags these days!) for visibility, in case we want to have the same group who worked on the VBA flows take this one as well.

  3. self-assigned this
    on Feb 16, 2024
  4. mountiny commented on Feb 16, 2024

    @mountiny
    Contributor

    Thanks for the ping! We could ask Callstack due to their experience with this. I am curious though, I am not that familiar with the backend for this flow so curious if there would any changes be required there. @MariaHCD do you think you could chime in? I assume from what I could read the order of the steps is more or less the same.

    We are not moving any checkboxes or any inputs to different steps right? (asking because we had that issue in the bank refactor and had to make changes to the backend slightly)

  5. anmurali commented on Feb 16, 2024

    @anmurali
    Author

    So far as I can tell, we're not changing any inputs. The only thing worth double clicking on is Current Verify Identity step
    We currently show
    image

    I want to change that to
    image

  6. mountiny commented on Feb 16, 2024

    @mountiny
    Contributor

    Nice, that sounds like basically just UI change!

    @koko57 I heard you are keen on helping with this :) if so would you like to comment so I can assign you?

  7. self-assigned this
    on Feb 16, 2024
  8. koko57 commented on Feb 16, 2024

    @koko57
    Contributor

    yes I was typing the message right now! 😃 I'm ready to help

  9. MariaHCD commented on Feb 19, 2024

    @MariaHCD
    Contributor

    the backend for this flow so curious if there would any changes be required there. @MariaHCD do you think you could chime in? I assume from what I could read the order of the steps is more or less the same.

    The order of the steps looks the same to me too:

    1. AdditionalDetails step - which calls the UpdatePersonalDetailsForWallet API command
    2. Onfido step - which calls the OpenOnfidoFlow API command to initialize the flow, followed by VerifyIdentity
    3. Terms step - which calls AcceptWalletTerms

    The KYC flow is outlined in this SO (in case it is helpful)

  10. MariaHCD commented on Feb 19, 2024

    @MariaHCD
    Contributor

    One thing I'd like to add is regarding Knowledge Based Authentication (KBA) questions. @anmurali I'm assuming we still want to have these questions displayed to the user?

  11. mountiny commented on Feb 19, 2024

    @mountiny
    Contributor

    🚀 perfect! @shawnborton will we need any more details? Maybe share a Figma file with Agata?

    @MariaHCD Thank you, very helpful!

    Noting here as well this is to help with testing https://stackoverflowteams.com/c/expensify/questions/10607/11542#11542

  12. shawnborton commented on Feb 19, 2024

    @shawnborton
    Contributor

    This is the Figma file we have been using.

  13. mountiny commented on Feb 19, 2024

    @mountiny
    Contributor

    Thanks, shared with Agata!

  14. 164 remaining items

  15. muttmuure commented on Aug 6, 2024

    @muttmuure
    Contributor
  16. DylanDylann commented on Aug 6, 2024

    @DylanDylann
    Contributor

    @muttmuure Thanks 🙏 , I applied to the job

  17. muttmuure commented on Aug 8, 2024

    @muttmuure
    Contributor

    Offer sent

  18. muttmuure commented on Aug 9, 2024

    @muttmuure
    Contributor

    Waiting for offer to be accepted

  19. DylanDylann commented on Aug 10, 2024

    @DylanDylann
    Contributor

    @muttmuure Offer accepted with thanks!

  20. melvin-bot commented on Aug 13, 2024

    @melvin-bot

    @shawnborton, @Pujan92, @koko57, @mountiny, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

  21. mountiny commented on Aug 14, 2024

    @mountiny
    Contributor

    I believe we can close this one now, right?

  22. DylanDylann commented on Oct 16, 2024

    @DylanDylann
    Contributor

    @muttmuure My contract for this issue is unpaid as of now, can you assist in releasing payments?

  23. muttmuure commented on Oct 18, 2024

    @muttmuure
    Contributor

    Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions