Skip to content

[HOLD for payment 2024-02-26] [$500] Cancel payment - No red dot in expense preview in main chat when payment cancellation fails #36695

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Admin and member are in the same free workspace.
  • Admin and member have bank account set up.
  1. [Member] Go to workspace chat.
  2. [Member] Create a manual request.
  3. [Admin] Pay the request with Expensify.
  4. [Admin] Go to expense report > 3-dot menu > Cancel payment.
  5. [Admin] Cancel the payment.
  6. [Admin] Return to the main chat without dismissing the error.

Expected Result:

The expense preview in the main chat will display red dot.

Actual Result:

The expense preview in the main chat does not display red dot.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6381881_1708089806249.bandicam_2024-02-16_16-46-11-493.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018a0ba8089a65a1dd
  • Upwork Job ID: 1758487283174920192
  • Last Price Increase: 2024-02-16

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 16, 2024
  2. changed the title [-]Cancel payment - No red dot in expense preview in main chat when payment cancellation fails[/-] [+][$500] Cancel payment - No red dot in expense preview in main chat when payment cancellation fails[/+] on Feb 16, 2024
  3. melvin-bot commented on Feb 16, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 16, 2024
  5. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  6. github-actions commented on Feb 16, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. kbecciv commented on Feb 16, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave5-free-submitters
    CC @dylanexpensify

  9. 13 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 19, 2024
  11. changed the title [-][$500] Cancel payment - No red dot in expense preview in main chat when payment cancellation fails[/-] [+][HOLD for payment 2024-02-26] [$500] Cancel payment - No red dot in expense preview in main chat when payment cancellation fails[/+] on Feb 19, 2024
  12. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-26. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @slafortune you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  15. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@slafortune)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1758487283174920192/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. aimane-chnaif commented on Feb 26, 2024

    @aimane-chnaif
    Contributor

    I didn't review linked PR. We can close this

  17. slafortune commented on Feb 26, 2024

    @slafortune
    Contributor

    Thanks @aimane-chnaif ! I see that payment for the reviewer is being handled here - #36599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions