Skip to content

[HOLD for payment 2024-03-29] [$500] Not able to get the Hybrid app to go into NewDot app #36717

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.42-1 and OD app version 8.5.39
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielvldal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708054233917059

Action Performed:

  1. Open OD app
  2. Tap on "Try New Expensify

Expected Result:

Use lands in ND app

Actual Result:

The link in the page is not clickable and can't go back

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1708101997.MP4

IMG_4806

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f8c5a663acb0d15e
  • Upwork Job ID: 1758536328807780352
  • Last Price Increase: 2024-02-16

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 16, 2024
  2. changed the title [-]Not able to get the Hybrid app to go into NeDot app[/-] [+][$500] Not able to get the Hybrid app to go into NeDot app[/+] on Feb 16, 2024
  3. melvin-bot commented on Feb 16, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 16, 2024
  5. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  6. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. self-assigned this
    on Feb 16, 2024
  8. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 16, 2024
  9. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

  10. 39 remaining items

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 22, 2024
  12. changed the title [-][$500] Not able to get the Hybrid app to go into NewDot app[/-] [+][HOLD for payment 2024-03-29] [$500] Not able to get the Hybrid app to go into NewDot app[/+] on Mar 22, 2024
  13. melvin-bot commented on Mar 22, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-29. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @danielvldal requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on Mar 22, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav] Determine if we should create a regression test for this bug.
    • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. mananjadhav commented on Mar 31, 2024

    @mananjadhav
    Collaborator

    @roryabraham @AndrewGable Will there by any partial payout for the first review that I did on the PR?

  16. AndrewGable commented on Apr 17, 2024

    @AndrewGable
    Contributor

    Yes, you reviewed so payout is eligible 👍

  17. mananjadhav commented on Apr 17, 2024

    @mananjadhav
    Collaborator

    @anmurali can you please add a payout summary for this one ?

  18. mananjadhav commented on Apr 23, 2024

    @mananjadhav
    Collaborator

    @anmurali quick bump

  19. anmurali commented on Apr 23, 2024

    @anmurali

    -[ ] $250 to @mananjadhav approved per Slack conversation on ND

  20. mananjadhav commented on Apr 23, 2024

    @mananjadhav
    Collaborator
  21. JmillsExpensify commented on Apr 25, 2024

    @JmillsExpensify
    Contributor

    $250 approve for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions