Skip to content

[$500] [Held requests] - Pressing 'Enter' key doesn't serve as clicking on 'Got it' button #36825

New issue
New issue
Closed
Closed
[$500] [Held requests] - Pressing 'Enter' key doesn't serve as clicking on 'Got it' button#36825
Assignees
techievivekBartoszGrajdekabdulrahuman5196muttmuuredukenv0307
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Description

@kavimuru
kavimuru
opened on Feb 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Sign up with a new account
  2. Create an IOU with a user
  3. Navigate to IOU reports details page
  4. Click on three dot > Hold request > enter reason > press enter
  5. Hitting enter key the first time navigates to Expense header RHP.
  6. Press enter again.

Expected Result:

Pressing enter after entering the reason should close the RHP. And pressing enter should behave as clicking on 'Got it' button

Actual Result:

Nothin happens

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385200_1708391360465.Screen_Recording_2024-02-20_at_3.06.17_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017589b7378e34e844
  • Upwork Job ID: 1759789310076301312
  • Last Price Increase: 2024-08-20
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 0
    • dukenv0307 | Contributor | 103623715
Issue OwnerCurrent Issue Owner: @

Activity

  1. kavimuru
    added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. melvin-bot
    changed the title [-]Hold Request - Pressing 'Enter' key doesn't serve as clicking on 'Got it' button[/-] [+][$500] Hold Request - Pressing 'Enter' key doesn't serve as clicking on 'Got it' button[/+] on Feb 20, 2024

  3. melvin-bot commented on Feb 20, 2024

    @melvin-bot
    melvin-botBot
    on Feb 20, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~017589b7378e34e844

  4. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot
    assigned
    abdulrahuman5196
    on Feb 20, 2024

  6. melvin-bot commented on Feb 20, 2024

    @melvin-bot
    melvin-botBot
    on Feb 20, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

  7. melvin-bot
    assigned
    muttmuure
    on Feb 20, 2024

  8. melvin-bot commented on Feb 20, 2024

    @melvin-bot
    melvin-botBot
    on Feb 20, 2024 – with Melvin Bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Feb 20, 2024

  10. github-actions commented on Feb 20, 2024

    @github-actions
    github-actionsBot
    on Feb 20, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  11. 100 remaining items

  12. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Aug 22, 2024

  13. dukenv0307 commented on Aug 22, 2024

    @dukenv0307
    dukenv0307
    on Aug 22, 2024
    Contributor

    @abdulrahuman5196 The PR is ready for review.

  14. techievivek commented on Sep 10, 2024

    @techievivek
    techievivek
    on Sep 10, 2024
    Contributor

    I think we can move with the payment here now since it's been more than 2 weeks since PR has been deployed to PROD. CC @muttmuure

  15. abdulrahuman5196 commented on Sep 14, 2024

    @abdulrahuman5196
    abdulrahuman5196
    on Sep 14, 2024
    Contributor

    The PR that introduced the bug has been identified. Link to the PR:
    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Doesn't seem to be a regression.

    Determine if we should create a regression test for this bug.

    Yes.

    If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Login with an account that doesn't hold any request
    2. Submit an expense
    3. Open the hold reason page
    4. Enter the reason and go to the next page
    5. Press enter key and verify that RHP is closed

    @muttmuure

  16. techievivek commented on Sep 16, 2024

    @techievivek
    techievivek
    on Sep 16, 2024
    Contributor

    Regression test looks good to me, @muttmuure can we please get that added to testRail? Thanks

  17. muttmuure
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Sep 17, 2024

  18. muttmuure commented on Sep 17, 2024

    @muttmuure
    muttmuure
    on Sep 17, 2024
    Contributor

    $500 - @dukenv0307
    $500 - @abdulrahuman5196

  19. robertjchen commented on Sep 23, 2024

    @robertjchen
    robertjchen
    on Sep 23, 2024
    Contributor

    I think we're all set here? Please comment if there are any other remaining steps

  20. robertjchen
    closed this as completedon Sep 23, 2024
  21. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Sep 23, 2024

  22. JmillsExpensify commented on Sep 23, 2024

    @JmillsExpensify
    JmillsExpensify
    on Sep 23, 2024
    Contributor

    $500 approved for @abdulrahuman5196

  23. dukenv0307 commented on Oct 1, 2024

    @dukenv0307
    dukenv0307
    on Oct 1, 2024
    Contributor

    $500 - @dukenv0307

    @muttmuure Could you please release the payment on Upwork for my job?

    Thank you 🙏

  24. muttmuure commented on Oct 16, 2024

    @muttmuure
    muttmuure
    on Oct 16, 2024
    Contributor

    Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions