Skip to content

[Awaiting payment 7th March] [$500] Hold Request - 'Reason' is not translated to Spanish #36826

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Change app language preference to Spanish
  2. Create an IOU with a user
  3. Navigate to IOU reports details page
  4. Click on three dot > Hold request

Expected Result:

'Reason' in the input field should be translated into Spanish

Actual Result:

'Reason' in the input field is not translated into Spanish

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385205_1708391701820.Screen_Recording_2024-02-20_at_3.16.25_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01470739ce07ee196a
  • Upwork Job ID: 1759790323341258752
  • Last Price Increase: 2024-02-20

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  3. changed the title [-] Hold Request - 'Reason' is not translated to Spanish[/-] [+][$500] Hold Request - 'Reason' is not translated to Spanish[/+] on Feb 20, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  6. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 9 remaining items

  9. trjExpensify commented on Feb 20, 2024

    @trjExpensify
    Contributor

    I'm going to remove the Help wanted and External labels, as Monil has a PR up for this.

    contributors spent time and effort to make sure the cause is identified and the blocker is fixed quickly.

    I would probably agree if we aren't talking about a missing Spanish translation.

  10. BartoszGrajdek commented on Feb 20, 2024

    @BartoszGrajdek
    Contributor

    @MonilBhavsar already started working on a fix, so I'm not going to create a follow-up PR, let me know if I can help you with anything though! 👀

  11. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 20, 2024
  12. trjExpensify commented on Feb 27, 2024

    @trjExpensify
    Contributor

    Sounds good! Deployed to staging, so awaiting prod deploy and regression period to pay out @situchan for the review.

  13. melvin-bot commented on Mar 5, 2024

    @melvin-bot

    @trjExpensify, @MonilBhavsar, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. melvin-bot commented on Mar 5, 2024

    @melvin-bot

    @trjExpensify, @MonilBhavsar, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. trjExpensify commented on Mar 7, 2024

    @trjExpensify
    Contributor

    @situchan offer sent for the C+ review.

  16. changed the title [-][$500] Hold Request - 'Reason' is not translated to Spanish[/-] [+][Awaiting payment 7th March] [$500] Hold Request - 'Reason' is not translated to Spanish[/+] on Mar 7, 2024
  17. trjExpensify commented on Mar 7, 2024

    @trjExpensify
    Contributor

    Settled up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions