Repository navigation
[$500] Video file is unusable when editing name #36828
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Send a video
- Edit the video name, and leave the file type extension unedited
Expected Result:
Video file shouldn't be lost or user shouldn't be able to edit the name
Actual Result:
Video file is lost
Workaround:
unknwon
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6385214_1708393282361.Screen_Recording_2024-02-16_at_4.00.11_in_the_afternoon.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0100912197a0a59053
- Upwork Job ID: 1759792164480184320
- Last Price Increase: 2024-02-20
Activity
[-]Video file is unusable when editing name[/-][+][$500] Video file is unusable when editing name[/+]melvin-bot commentedon Feb 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0100912197a0a59053
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)github-actions commentedon Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
2 remaining items
kavimuru commentedon Feb 20, 2024
we think this bug might be related to #vip-vsb
cc @quinthar
shubham1206agra commentedon Feb 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue
Video file is unusable when editing name
What is the root cause of that problem?
We should not allow editing video upload same as pdf files.
What changes do you think we should make in order to solve the problem?
Disable edit operation on video upload comment. Update
canEditReportActionto give false on video comment.What alternative solutions did you explore? (Optional)
habasefa commentedon Feb 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue
Video file is unusable when editing name
What is the root cause of that problem?
The comment should not update the file name of the video, but a separate prop.
What changes do you think we should make in order to solve the problem?
Add a prop that will have the video file name as the default but can be independantly edited.
What alternative solutions did you explore? (Optional)
shubham1206agra commentedon Feb 20, 2024
@techievivek Can you check if this can be fixed from the Backend as the message should be
[Attachment]instead of the filename?mkhutornyi commentedon Feb 20, 2024
This looks similar to #35578
Ideally, this should be fixed in backend as I said here
techievivek commentedon Feb 20, 2024
@shubham1206agra Taking a look now, thanks.
techievivek commentedon Feb 20, 2024
@shubham1206agra
You meant when the user clicks on the edit button we should be showing
[Attachment]rather than displaying the file name?shubham1206agra commentedon Feb 20, 2024
No, I mean text format of message should come as
[Attachment]from BE which same as pdf attachment.mollfpr commentedon Feb 20, 2024
I don’t understand the purpose of editing the video comment.
@techievivek Are this feature that expected to be working for a video message?
techievivek commentedon Feb 20, 2024
Yes, I agree. We should disable editing the comment from the frontend. However, for completeness, we should also address this on the backend to handle potential requests from other clients correctly.
mollfpr commentedon Feb 20, 2024
Seems a good plan for me 👍
I think we can handled the issue here #35578
techievivek commentedon Feb 20, 2024
This shouldn't block the deploy IMO, and I agree we can handle this as part of #35578
techievivek commentedon Feb 20, 2024
Going to close this now, we are handling this here #35578 (comment)