Repository navigation
[$500] WS avatar does not have any indent from the bottom edge of the header #36835
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
- Launch App
- Navigate to any WS
- Tap settings > Profile
Expected Result:
WS avatar should have an indent from the bottom edge of the header
Actual Result:
WS avatar does not have any indent from the bottom edge of the header.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6385261_1708398822692.Screen_Recording_2024-02-19_at_9.12.41_PM.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c86444f0c4b200d4
- Upwork Job ID: 1759797554514292736
- Last Price Increase: 2024-02-20
Activity
[-]WS avatar does not have any indent from the bottom edge of the header[/-][+][$500] WS avatar does not have any indent from the bottom edge of the header[/+]melvin-bot commentedon Feb 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01c86444f0c4b200d4
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
4 remaining items
situchan commentedon Feb 20, 2024
#36426
cc: @narefyev91 @allroundexperts
narefyev91 commentedon Feb 20, 2024
i will take care of it
narefyev91 commentedon Feb 20, 2024
@situchan @allroundexperts ready to go #36844
tienifr commentedon Feb 21, 2024
@puneetlath Should we have a payment here since we used my proposal to fix this blocker?
Similar case: https://expensify.slack.com/archives/C01GTK53T8Q/p1707782382926619?thread_ts=1707781846.347169&cid=C01GTK53T8Q
puneetlath commentedon Feb 21, 2024
Interesting, fair question, but this doesn't feel the same as the linked case. In this case it doesn't feel like your exact proposal was used. It was a simple fix that the original contributor raised on their own. And you didn't find the offending PR, so I don't think any compensation is due here.
puneetlath commentedon Feb 21, 2024
Closing since the PR was raised by the original C/C+ and CP'd to staging. Thanks for the quick fix!
shawnborton commentedon Feb 26, 2024
So we actually don't want any space below the avatar and the background image:
The problem is that in light mode, we aren't using the right background image.
situchan commentedon Feb 26, 2024
There's bug in dark mode as well. Background image is cut, not stretched gradiently to the bottom
shawnborton commentedon Feb 26, 2024
Yeah, I think we need a follow up here with new images for the header area for both light and dark mode. And we need to revert this change. I also outlined a few more issues: