Skip to content

[HOLD #36894] [$500] [Held requests] "Reason" text is copied twice when using "Copy to clipboard" #36837

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid account
  3. Create a money request with any user
  4. Click on 3 dot menu in top right > "Hold/unhold request" > Hold the comment and input a reason like "7"
  5. On the "held this money request with the comment: 7" text, long press and click on "Copy to clipboard"
  6. Paste this text

Expected Result:

User expects that "held this money request with the comment: 7" is copied in this case

Actual Result:

The reason is always copied twice, it will be pasted as "held this money request with the comment: 77"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385269_1708399154112.Reason_is_copied_twice_to_clipboard.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01180936b0aa255ca4
  • Upwork Job ID: 1759798757126152192
  • Last Price Increase: 2024-02-20

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. changed the title [-]Hold Request - "Reason" text is not copied twice when using "Copy to clipboard"[/-] [+][$500] Hold Request - "Reason" text is not copied twice when using "Copy to clipboard"[/+] on Feb 20, 2024
  3. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  6. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 16 remaining items

  9. robertjchen commented on Feb 29, 2024

    @robertjchen
    Contributor

    On hold, pending changes in #36979

  10. changed the title [-][HOLD #36894] [$500] Hold Request - "Reason" text is copied twice when using "Copy to clipboard"[/-] [+][HOLD #36894] [$500] [Held requests] "Reason" text is copied twice when using "Copy to clipboard"[/+] on Mar 8, 2024
  11. slafortune commented on Mar 8, 2024

    @slafortune
    Contributor

    Still on hold

  12. robertjchen commented on Mar 18, 2024

    @robertjchen
    Contributor

    On hold, pending changes in #36979

  13. slafortune commented on Mar 22, 2024

    @slafortune
    Contributor

    Can this be taken off hold now @robertjchen ?

  14. robertjchen commented on Mar 22, 2024

    @robertjchen
    Contributor

    This one can actually be closed out, since the comment is now in a dedicated comment moving forward and the issue here no longer applies 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions