Skip to content

[$500] Chat - For video uploaded, download option is not shown. #36861

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap on a report with mp4 video and image attachment
  3. Long press the mp4 video message and note context menu options
  4. Long press the image message and note context menu options

Expected Result:

For video uploaded, download option must be shown.

Actual Result:

For video uploaded, download option is not shown but it is shown for image attachment message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6385326_1708404424195.az_recorder_20240220_070316.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016eea6865de64afb6
  • Upwork Job ID: 1759891713374605312
  • Last Price Increase: 2024-02-20

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. changed the title [-]Chat - For video uploaded, download option is not shown.[/-] [+][$500] Chat - For video uploaded, download option is not shown.[/+] on Feb 20, 2024
  3. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  6. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 12 remaining items

  9. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  10. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

  11. Tony-MK commented on Feb 20, 2024

    @Tony-MK
    Contributor

    This should be fixed by #36312.

    Read #35578 (comment).

  12. francoisl commented on Feb 20, 2024

    @francoisl
    Contributor

    Eh, that solution works but I'm not a big fan of that change in isReportMessageAttachment, we wouldn't need that after ensuring the backend returns [Attachment] for the text prop of the message.

    I'll still keep this issue open to track the backend changes.

  13. twisterdotcom commented on Feb 26, 2024

    @twisterdotcom
    Contributor

    Looks like this should be Reviewing right @francoisl?

  14. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    @francoisl, @twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. twisterdotcom commented on Mar 4, 2024

    @twisterdotcom
    Contributor

    This was merged and deployed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions