You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Chat - For video uploaded, download option is not shown. #36861
Version Number: 1.4.43-0 Reproducible in staging?: Y Reproducible in production?: N Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation:
Action Performed:
Launch app
Tap on a report with mp4 video and image attachment
Long press the mp4 video message and note context menu options
Long press the image message and note context menu options
Expected Result:
For video uploaded, download option must be shown.
Actual Result:
For video uploaded, download option is not shown but it is shown for image attachment message.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Chat - For video uploaded, download option is not shown.[/-][+][$500] Chat - For video uploaded, download option is not shown.[/+]on Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Eh, that solution works but I'm not a big fan of that change in isReportMessageAttachment, we wouldn't need that after ensuring the backend returns [Attachment] for the text prop of the message.
I'll still keep this issue open to track the backend changes.
Activity
[-]Chat - For video uploaded, download option is not shown.[/-][+][$500] Chat - For video uploaded, download option is not shown.[/+]melvin-bot commentedon Feb 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~016eea6865de64afb6
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
12 remaining items
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (
Internal)Tony-MK commentedon Feb 20, 2024
This should be fixed by #36312.
Read #35578 (comment).
francoisl commentedon Feb 20, 2024
Eh, that solution works but I'm not a big fan of that change in
isReportMessageAttachment, we wouldn't need that after ensuring the backend returns[Attachment]for thetextprop of the message.I'll still keep this issue open to track the backend changes.
twisterdotcom commentedon Feb 26, 2024
Looks like this should be
Reviewingright @francoisl?melvin-bot commentedon Mar 4, 2024
@francoisl, @twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!
twisterdotcom commentedon Mar 4, 2024
This was merged and deployed. Closing.