[$500] Fab - Hidden not displayed on chat header & LHN when creating an IOU

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.43-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Click on FAB > Request money > enter amount
Select a new user that has ND account > Click on 'Request' button

Expected Result:

Hidden should be displayed in LHN & report header

Actual Result:

Hidden is not displayed in LHN & report header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6385574_1708425964747.Screen_Recording_2024-02-20_at_3.44.04_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015ea497aa7819e170
Upwork Job ID: 1759944064634163200
Last Price Increase: 2024-02-20

Job added to Upwork: https://www.upwork.com/jobs/~015ea497aa7819e170

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@flodnv

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@davidcardoza

We think that this bug might be related to #vip-bills
CC @davidcardoza

I've noticed a discrepancy in behavior between production and staging. In production, the avatar of a user whom I've never chatted with before, but who has an ND account, is displayed in the header. However, in staging, the user's avatar is displayed as a skeleton in both the header and LHN.

Production

Recording.6036.mp4

Staging

Recording.6035.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hidden is not displayed in LHN & report header

What is the root cause of that problem?

When we create a money request with a new user, we have a report action is report preview action so OpenReport API isn't called in ReportScreen here

App/src/pages/home/ReportScreen.js

Line 358 in 5f84683

    
           if (report.reportID && report.reportID === getReportID(route) && !isLoadingInitialReportActions) {

And after requestMoney API is complete, we don't update isOptimisticReport in successData as false so OpenReport API isn't called here

App/src/pages/home/report/ReportActionsView.js

Line 108 in 5f84683

if (props.report.isOptimisticReport || !_.isEmpty(createChatError)) {

After all above, because OpenReport isn't called, personal detail of new user isn't returned that makes Header show skeleton and LHN doesn't show Hidden

What changes do you think we should make in order to solve the problem?

We should update isOptimisticReport of all new report when we create a request money to false in successData so when requestMoney is complete, openReport API can be called.

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport.reportID}`,
    value: {
        isOptimisticReport: false,
        pendingFields: null,
        errorFields: null,
    },
},
{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${chatReport?.reportID}`,
    value: {
        isOptimisticReport: false,
    },
},

App/src/libs/actions/IOU.ts

Line 530 in 29ad878

successData.push(

And add props.report. isOptimisticReport as a dependency here

App/src/pages/home/report/ReportActionsView.js

Line 118 in 29ad878

}, []);

What alternative solutions did you explore? (Optional)

NA

@dukenv0307

@dukenv0307 Do you suggest applying isOptimisticReport to report or reportAction? It seems your permalink taking us to success data of reportAction

@DylanDylann

@DylanDylann I suggest to update the report data as the preview code in my proposal. The permalink is only linked to the successData.

But your permalink linked to success data or report action

@DylanDylann

@DylanDylann I updated #36885, sorry for the confusion.

@dukenv0307

@dukenv0307 Could you reproduce this issue on the latest main?
I can't reproduce anymore. This is my log, It is different from RCA in your proposal

@DylanDylann

@DylanDylann Also can't reproduce on the latest main but I found another in the latest main:

Create money request in offline show skeleton instead of the grey out report.

cc @greg-schroeder

Screen.Recording.2024-02-23.at.16.40.45.mov

@chiragsalian

@chiragsalian @flodnv we can't reproduce the original issue anymore, so I think we should remove deployBlocker label in this issue. And we also should consider to fix above bug that is mentioned by @dukenv0307

@dukenv0307

Sounds good, removing the blocker label and checking it off the checklist. I'd suggest to create another issue to tackle the bug that @dukenv0307 brought up.

@chiragsalian

@chiragsalian Reported bug here. Let's close this one

Navigation Menu

Repository navigation

[$500] Fab - Hidden not displayed on chat header & LHN when creating an IOU #36885

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

5 remaining items

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] Fab - Hidden not displayed on chat header & LHN when creating an IOU #36885

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 20, 2024

melvin-bot commented on Feb 20, 2024

github-actions commented on Feb 20, 2024

melvin-bot commented on Feb 20, 2024

kbecciv commented on Feb 20, 2024

5 remaining items

kbecciv commented on Feb 20, 2024

dukenv0307 commented on Feb 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

DylanDylann commented on Feb 23, 2024

dukenv0307 commented on Feb 23, 2024

DylanDylann commented on Feb 23, 2024

dukenv0307 commented on Feb 23, 2024

DylanDylann commented on Feb 23, 2024

dukenv0307 commented on Feb 23, 2024

DylanDylann commented on Feb 23, 2024

chiragsalian commented on Feb 23, 2024

DylanDylann commented on Feb 25, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions