[HOLD for payment 2024-03-13] [$500] Workspace – Unable to save edited WS name using Enter key in newly created WS.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.43-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4327666
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Login with account that has at least 1 WS already created
Click on "choose Workspace" icon in top left
Create a new WS by hitting "+"
Edit WS name
Press Enter key to save the edited WS name

Expected Result:

Edited WS name is saved

Actual Result:

Nothing happens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6385818_1708442372353.Unable_to_save_edited_WS_name_using_Enter_key.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0109e93e51a9b4c9ed
Upwork Job ID: 1760135649726885888
Last Price Increase: 2024-02-21
Automatic offers:

getusha | Reviewer | 0
bernhardoj | Contributor | 0

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace – Unable to save edited WS name using Enter key in newly created WS.

What is the root cause of that problem?

We don't pass disablePressOnEnter={false} to FormProvider in WorkspaceNamePage

App/src/pages/workspace/WorkspaceNamePage.tsx

Line 66 in 669ac33

<FormProvider

What changes do you think we should make in order to solve the problem?

Pass disablePressOnEnter={false} to FormProvider in WorkspaceNamePage

Result

Can't reproduce on v1.4.43-5

2024-02-21_13-54-48.mp4

Able to reproduce.
Issue is repro ONLY if you already have a WS created. If you are creating 1st one its not repro

Screen.Recording.2024-02-20.at.8.53.51.PM.mov

Still unable to repro:

2024-02-21_15-39-18.mp4

Ah wait, I clicked the wrong "create a workspace" button. Was able to repro this.

Job added to Upwork: https://www.upwork.com/jobs/~0109e93e51a9b4c9ed

@getusha

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@bernhardoj

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix can't save workspace name using ENTER key after creating a new workspace from workspace switcher page #37069

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

@bernhardoj requires payment automatic offer (Contributor)
@getusha requires payment automatic offer (Reviewer)

@getusha

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: Prevent enter key event if the focused element is a clickable element #32464
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32464/files#r1521968148
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/378645

@getusha

@getusha don't forget the checklist!

@getusha

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: Prevent enter key event if the focused element is a clickable element #32464
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32464/files#r1521968148
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open workspace switcher page
Create new workspace (+ icon)
Open workspace profile page
Press on the workspace name
Edit the name
Press enter/return
Verify the name is saved and the page is closed

Do we agree 👍 or 👎

@bernhardoj

Payouts due:

Contributor: $500 @bernhardoj
Contributor+: $500 @getusha

Upwork job is here.

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-13] [$500] Workspace – Unable to save edited WS name using Enter key in newly created WS. #36923

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms: