Skip to content

[HOLD for payment 2024-03-18] [$500] [Simplified Collect][Profile] Invite flow #36946

Closed

Description

@luacmartins

Implement the invite flow from the Simplified Collect: Profile, Members, Categories design doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01163b2b848dd14d88
  • Upwork Job ID: 1760043376483004416
  • Last Price Increase: 2024-02-20

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. self-assigned this
    on Feb 20, 2024
  3. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. luacmartins commented on Feb 20, 2024

    @luacmartins
    ContributorAuthor

    @narefyev91 please comment here so I can assign you to this issue!

  5. narefyev91 commented on Feb 20, 2024

    @narefyev91
    Contributor

    Hi! I'm Nicolay from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 20, 2024
  7. changed the title [-][Simplified Collect][Profile] Invite flow[/-] [+][$500] [Simplified Collect][Profile] Invite flow[/+] on Feb 20, 2024
  8. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  10. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  11. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  12. 32 remaining items

  13. rushatgabhane commented on Mar 16, 2024

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: N.A. This is a new feature.

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

    4. Determine if we should create a regression test for this bug. Yes because new feature.

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

      Preconditions:

      1. Has a workspace (new or existing one)
      2. Prepare join url link - use WorkspaceID and admin email for that workspace - ex. https://dev.new.expensify.com:8082/workspace/7DE6960B26D79E36/join?email=tenema5675@bizatop.com

      For user:

      1. Open link in a new tab (for a new user / or user which already logged in)
      2. Verify that loading indicator is shown
      3. Verify that user redirects to all workspaces screen
      4. Verify that user sees a new line with workspace (in which join link was executed) and user sees chip with text "Requested"
      5. Verify that user could not interact with that workspace
      6. Wait until admin accept/decline request - verify that user will have/not have access to the workspace

      For Admin:

      1. When user used join link - verify that a new message is shown in admin room for that workspace
      2. Verify that 2 buttons are shown - "Accept"/"Decline"
      3. Click on any of them - verify that API request will be send, verify that message will be removed from admin room
  14. rushatgabhane commented on Mar 16, 2024

    @rushatgabhane
    Member

    @dylanexpensify could you please attach payment summary. Thanks 🙇

  15. JmillsExpensify commented on Mar 18, 2024

    @JmillsExpensify
    Contributor

    Awaiting payment summary.

  16. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@dylanexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1760043376483004416/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. dylanexpensify commented on Mar 19, 2024

    @dylanexpensify
    Contributor

    Payment summary:

    Please apply/request!

  18. moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Mar 19, 2024
  19. JmillsExpensify commented on Mar 22, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @rushatgabhane.

  20. added
    ReviewingHas a PR in review
    and removed on May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions