Skip to content

[BZ checklist] [$500] [Held requests] IOS - Hold Request - Keyboard is up but the field is not focused with error message showing #36948

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch New Expensify app
  2. Create a manual request from any user
  3. Navigate to request details page
  4. Tap 3-dot menu > Hold request
  5. Close the menu
  6. Tap 3-dot menu > Hold request

Expected Result:

The "Reason" field will be focused

Actual Result:

Keyboard is up but the field is not focused with error message showing up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385952_1708450041705.RPReplay_Final1708393963.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014db792b47c7bf65e
  • Upwork Job ID: 1760046429209067520
  • Last Price Increase: 2024-02-20
  • Automatic offers:
    • situchan | Reviewer | 0
    • Krishna2323 | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 20, 2024
  2. changed the title [-]IOS - Hold Request - Keyboard is up but the field is not focused with error message showing[/-] [+][$500] IOS - Hold Request - Keyboard is up but the field is not focused with error message showing[/+] on Feb 20, 2024
  3. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  6. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. lanitochka17 commented on Feb 20, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-bills
    CC @davidcardoza

  9. 57 remaining items

  10. bfitzexpensify commented on Apr 9, 2024

    @bfitzexpensify
    Contributor

    Payment to @situchan done.

    @situchan, adding a manual BZ checklist here - please complete! Thanks

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. changed the title [-][Awaiting C+ payment] [$500] [Held requests] IOS - Hold Request - Keyboard is up but the field is not focused with error message showing[/-] [+][BZ checklist] [$500] [Held requests] IOS - Hold Request - Keyboard is up but the field is not focused with error message showing[/+] on Apr 11, 2024
  12. melvin-bot commented on Apr 16, 2024

    @melvin-bot

    @neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. bfitzexpensify commented on Apr 16, 2024

    @bfitzexpensify
    Contributor

    Bump on the BZ checklist @situchan - thank you

  14. bfitzexpensify commented on Apr 19, 2024

    @bfitzexpensify
    Contributor

    Bumping again @situchan - thank you!

  15. bfitzexpensify commented on Apr 22, 2024

    @bfitzexpensify
    Contributor

    Ah, Situ is OOO. Will check back for when he's returned and bump this in Slack to be completed.

  16. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    @neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. melvin-bot commented on May 1, 2024

    @melvin-bot

    @neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan Eep! 4 days overdue now. Issues have feelings too...

  18. melvin-bot commented on May 3, 2024

    @melvin-bot

    @neil-marcellini, @bfitzexpensify, @Krishna2323, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  19. bfitzexpensify commented on May 4, 2024

    @bfitzexpensify
    Contributor

    Still OOO, will bump when back.

  20. bfitzexpensify commented on May 13, 2024

    @bfitzexpensify
    Contributor

    I'm going to close this one out myself.

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • The PR that introduced the bug has been identified. Link to the PR: polish, not a bug - [BZ checklist] [$500] [Held requests] IOS - Hold Request - Keyboard is up but the field is not focused with error message showing #36948 (comment)
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. No need, minor bug
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
    • Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions