Skip to content

[$1500] Create new library and native module react-native-wallet #36957

Closed

Description

@thienlnam

To support tokenization in NewDot which is adding a virtual card to Apple / Google Pay, we will need access to some native methods.

Problem:
Apple Pay and Google Pay are table stakes in the card market today. We support both of them for physical and virtual cards. Going forward, members will be able to access their virtual card details in NewDot. However, it isn't intuitive to know that you can copy your virtual card details, and manually key them into the Apple/Google wallet apps to tokenize your virtual card.

We're going to create a new package that will return the necessary parameters and call native methods for adding a card to the wallet

The endpoint we want to call is CreateDigitalWallet.
We will need to call native modules to fetch specific native variables to call CreateDigitalWallet

  • deviceID
  • certificates
  • nonce
  • nonceSignature

Then once we have the return values, we will call the native modules to add these to apple / google wallets

CreateDigitalWallet Summary

The parameters required for the new CreateDigitalWallet API/auth command are:

Mutual parameters Android specific parameters iOS specific parameters
1.appVersion 1.walletAccountID 2.deviceID 1.certificates 2.nonce 3.nonceSignature

The return values for the new CreateDigitalWallet API/auth command are:

Mutual return values Android return values iOS return values
1.cardToken 1.opaquePaymentCard 2.userAddress 3.network 4.tokenServiceProvider 5.displayName 6.lastDigits 1.encryptedPassData 2.activationData 3.ephemeralPublicKey
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e91e840e65f1cbba
  • Upwork Job ID: 1765158784361259008
  • Last Price Increase: 2025-07-05
  • Automatic offers:
    • brunovjk | Reviewer | 107119121
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. self-assigned this
    on Feb 20, 2024
  2. changed the title [-]Create new library react-native-wallet[/-] [+]Create new library and native module react-native-wallet[/+] on Mar 5, 2024
  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 5, 2024
  4. changed the title [-]Create new library and native module react-native-wallet[/-] [+][$500] Create new library and native module react-native-wallet[/+] on Mar 5, 2024
  5. melvin-bot commented on Mar 5, 2024

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 5, 2024
  7. melvin-bot commented on Mar 5, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  8. added
    NewFeatureSomething to build that is a new item.
    and removed on Mar 5, 2024
  9. melvin-bot commented on Mar 5, 2024

    @melvin-bot
  10. 260 remaining items

  11. akinwale commented on Jul 5, 2025

    @akinwale
    Contributor

    Ok thanks for the summary, I suggest we pay out $250 for reviewing the orifinal PR to @akinwale (while its large PR I think we should not really do more given the PR was not deployed in the end) and $1500 to @brunovjk for handling the remainder of the project

    I understand the suggestion due to the fact that there were additional tasks to get this across the finish line, and the reasons mentioned, but I feel that the proposed payment of $1,000 is due for C+ review taking into consideration the following:

    • The amount of work done: the proposal review, and the initial PR which was a large one that went through several rounds of reviews and feedback, at least three, if I recall correctly, if not more. This was due to the complexity of the issue.
    • The issue was created when the standard bounty was $500, and the price was raised to $1,000, also due to the complexity.
    • Based on the guidelines, contributors are eligible for the full payment if a solution superseding an existing PR was deployed, after the PR has been reviewed by the C+.

    Thanks in advance for reconsidering.

  12. mountiny commented on Jul 6, 2025

    @mountiny
    Contributor

    I have updated the summary to $500 but the issue has completely changed from what was intended at the start. I have checked the original pr and does not seem like there was extra amount of back and forth compared to normal PRs so $1000 would not be appropriate. I hope that is ok 🙌

  13. brunovjk commented on Jul 14, 2025

    @brunovjk
    Contributor

    Great, do we need anything else to continue with payment here? Regression tests have already been added, correct? Thanks

  14. akinwale commented on Jul 14, 2025

    @akinwale
    Contributor

    @lschurr It looks like this is ready for payment. While I am eligible for ND payments, my payment should be processed through Upwork since the issue was created before I became eligible.

  15. lschurr commented on Jul 14, 2025

    @lschurr
    Contributor

    Thanks all - Working on Upwork offers

  16. lschurr commented on Jul 14, 2025

    @lschurr
    Contributor

    Payment summary:

  17. lschurr commented on Jul 14, 2025

    @lschurr
    Contributor

    This should be all set!

  18. parasharrajat commented on Jul 28, 2025

    @parasharrajat
    Member

    Payment requested as per #36957 (comment)

  19. twisterdotcom commented on Jul 31, 2025

    @twisterdotcom
    Contributor

    @parasharrajat has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-5629-ae77-8fc5-caeed9f18201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions